chrome/installer/mac/app/NSAlert+ChromeInstallerAdditions.m - Issue 2203583002: Added unpacking step

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/installer/mac/app/NSAlert+ChromeInstallerAdditions.m

Issue 2203583002: Added unpacking step (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed all comments, rearranged app logic, rewrote test, a bit more error handling Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #import "NSAlert+ChromeInstallerAdditions.h"	5 #import "NSAlert+ChromeInstallerAdditions.h"

6	6

7 @implementation NSAlert (ChromeInstallerAdditions)	7 @implementation NSAlert (ChromeInstallerAdditions)

8 // In the one-button scenario, the button would be just "Quit." In the	8 // In the one-button scenario, the button would be just "Quit." In the

9 // two-button scenario, the first button would allow the user to "Retry" and	9 // two-button scenario, the first button would allow the user to "Retry" and

10 // the second button would provide the "Quit" option.	10 // the second button would provide the "Quit" option.

11 - (NSModalResponse)quitButton {	11 - (NSModalResponse)quitResponse {

12 return ([[self buttons] count] == 1) ? NSAlertFirstButtonReturn	12 return ([[self buttons] count] == 1) ? NSAlertFirstButtonReturn

13 : NSAlertSecondButtonReturn;	13 : NSAlertSecondButtonReturn;

14 }	14 }

15 @end	15 @end

OLD	NEW