Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2203573004: Do not mark prototype transitions as weak container in heap snapshot. (Closed)

Created:
4 years, 4 months ago by alph
Modified:
4 years, 4 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Do not mark prototype transitions as weak container in heap snapshot. Committed: https://crrev.com/99460bc4415c430b3a1056d61d0a51e3a40c063a Cr-Commit-Position: refs/heads/master@{#38252}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -13 lines) Patch
M src/profiler/heap-snapshot-generator.cc View 1 chunk +3 lines, -13 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
alph
4 years, 4 months ago (2016-08-02 14:23:15 UTC) #2
alph
4 years, 4 months ago (2016-08-02 14:23:15 UTC) #3
ulan
lgtm
4 years, 4 months ago (2016-08-02 14:25:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2203573004/1
4 years, 4 months ago (2016-08-02 14:47:56 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-02 15:23:21 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 15:25:20 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/99460bc4415c430b3a1056d61d0a51e3a40c063a
Cr-Commit-Position: refs/heads/master@{#38252}

Powered by Google App Engine
This is Rietveld 408576698