Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 2203553002: Add a user action for when the home button is clicked. (Closed)

Created:
4 years, 4 months ago by Ted C
Modified:
4 years, 4 months ago
Reviewers:
Yusuf
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a user action for when the home button is clicked. "Home" matches the existing desktop user action. BUG=633326 Committed: https://crrev.com/c0f485c00e97fb265b84a93b462f5b4f21eaf0f6 Cr-Commit-Position: refs/heads/master@{#409058}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Ted C
PTAL
4 years, 4 months ago (2016-08-01 20:26:38 UTC) #2
Yusuf
lgtm
4 years, 4 months ago (2016-08-01 20:29:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2203553002/1
4 years, 4 months ago (2016-08-01 20:32:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-01 21:21:14 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 21:24:38 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c0f485c00e97fb265b84a93b462f5b4f21eaf0f6
Cr-Commit-Position: refs/heads/master@{#409058}

Powered by Google App Engine
This is Rietveld 408576698