Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Unified Diff: extensions/browser/extensions_browser_client.h

Issue 220353002: Remove //chrome dependency from ExtensionPrefs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ContentSettingsService factory does not in fact depend on ExtensionPrefsFactory. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/extensions_browser_client.h
diff --git a/extensions/browser/extensions_browser_client.h b/extensions/browser/extensions_browser_client.h
index 2e3d26d8aede6914eb6d4679336179ee51ca8bcf..8f2c2ee8fa24dd2ad17ee332abb96f1c56efafcd 100644
--- a/extensions/browser/extensions_browser_client.h
+++ b/extensions/browser/extensions_browser_client.h
@@ -9,6 +9,7 @@
#include <vector>
#include "base/memory/scoped_ptr.h"
+#include "extensions/browser/extension_prefs.h"
James Cook 2014/04/01 22:09:37 I would extract ExtensionPrefsObserver into its ow
Ken Rockot(use gerrit already) 2014/04/01 22:41:37 Done.
class ExtensionFunctionRegistry;
class PrefService;
@@ -28,6 +29,7 @@ class ApiActivityMonitor;
class AppSorting;
class Extension;
class ExtensionHostDelegate;
+class ExtensionPrefs;
class ExtensionSystem;
class ExtensionSystemProvider;
@@ -90,6 +92,13 @@ class ExtensionsBrowserClient {
virtual PrefService* GetPrefServiceForContext(
content::BrowserContext* context) = 0;
+ // Populates a list of ExtensionPrefs observers to be attached to each
+ // BrowserContext's ExtensionPrefs upon construction. These observers
+ // are not owned by ExtenionPrefs.
James Cook 2014/04/01 22:09:37 "ExtensionPrefs"
Ken Rockot(use gerrit already) 2014/04/01 22:41:37 Done.
+ virtual void GetAdditionalExtensionPrefsObservers(
+ content::BrowserContext* context,
+ std::vector<ExtensionPrefs::Observer*>* observers) const = 0;
+
// Returns true if loading background pages should be deferred.
virtual bool DeferLoadingBackgroundHosts(
content::BrowserContext* context) const = 0;

Powered by Google App Engine
This is Rietveld 408576698