Remove //chrome dependency from ExtensionPrefs

extensions/browser/extension_prefs_factory.cc

Index: extensions/browser/extension_prefs_factory.cc
diff --git a/extensions/browser/extension_prefs_factory.cc b/extensions/browser/extension_prefs_factory.cc
index 4f59a6232501caee832bb2f7266404b477c37fe0..931b1045bd3a4c14cc49479642ef2ba53344937b 100644
--- a/extensions/browser/extension_prefs_factory.cc
+++ b/extensions/browser/extension_prefs_factory.cc
@@ -44,13 +44,16 @@ ExtensionPrefsFactory::~ExtensionPrefsFactory() {
 KeyedService* ExtensionPrefsFactory::BuildServiceInstanceFor(
     content::BrowserContext* context) const {
   ExtensionsBrowserClient* client = ExtensionsBrowserClient::Get();
-  return ExtensionPrefs::Create(
+  ExtensionPrefs* prefs = ExtensionPrefs::Create(
       client->GetPrefServiceForContext(context),
       context->GetPath().AppendASCII(extensions::kInstallDirectoryName),
       ExtensionPrefValueMapFactory::GetForBrowserContext(context),
       client->CreateAppSorting().Pass(),
-      client->AreExtensionsDisabled(
-          *CommandLine::ForCurrentProcess(), context));
+      client->AreExtensionsDisabled(*CommandLine::ForCurrentProcess(),

[James Cook, 2014/04/01 18:45:03]

Another way to do this might be to pass an optional observer into the Create()
method.

[Ken Rockot(use gerrit already), 2014/04/01 21:34:59]

True. I like this. Actually I'm going to have it take a vector of early
observers (I can't stomach adding a single special observer argument!) The EBC
method will populate a vector of observers.

ExtensionPrefsFactory will use this to populate its argument to Create.

+                                    context));
+  client->AddExtensionPrefsObservers(context, prefs);
+  prefs->Initialize();
+  return prefs;
 }
 
 content::BrowserContext* ExtensionPrefsFactory::GetBrowserContextToUse(