Remove //chrome dependency from ExtensionPrefs

chrome/browser/extensions/api/content_settings/content_settings_service.cc

Index: chrome/browser/extensions/api/content_settings/content_settings_service.cc
diff --git a/chrome/browser/extensions/api/content_settings/content_settings_service.cc b/chrome/browser/extensions/api/content_settings/content_settings_service.cc
new file mode 100644
index 0000000000000000000000000000000000000000..87b27773d538e76520f2783db97fcd021ce7ea58
--- /dev/null
+++ b/chrome/browser/extensions/api/content_settings/content_settings_service.cc
@@ -0,0 +1,81 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/extensions/api/content_settings/content_settings_service.h"
+
+#include "base/lazy_instance.h"
+#include "chrome/browser/extensions/api/content_settings/content_settings_store.h"
+#include "extensions/browser/extension_prefs_factory.h"
+#include "extensions/browser/extension_prefs_scope.h"
+#include "extensions/browser/pref_names.h"
+
+namespace extensions {
+
+namespace {}  // namespace

[James Cook, 2014/04/01 18:45:03]

delete this

[Ken Rockot(use gerrit already), 2014/04/01 21:34:59]

Nice.

+
+ContentSettingsService::ContentSettingsService(content::BrowserContext* context)
+    : content_settings_store_(new ContentSettingsStore()) {}
+
+ContentSettingsService::~ContentSettingsService() {}
+
+// static
+ContentSettingsService* ContentSettingsService::Get(
+    content::BrowserContext* context) {
+  return BrowserContextKeyedAPIFactory<ContentSettingsService>::Get(context);
+}
+
+// BrowserContextKeyedAPI implementation.
+BrowserContextKeyedAPIFactory<ContentSettingsService>*
+ContentSettingsService::GetFactoryInstance() {
+  static base::LazyInstance<

[James Cook, 2014/04/01 18:45:03]

Hrm. I'm not sure about this.  Usually these are file-level static variables.  I
doubt it matters here but I wonder if LazyInstance's thread safety guarantees
are still met with this usage pattern.  Not sure.

[Ken Rockot(use gerrit already), 2014/04/01 21:34:59]

I believe it's actually preferred, since it limits the scope and has no
undesirable side effects. Initialization time is a non-issue since LazyInstance
a POD type.

+      BrowserContextKeyedAPIFactory<ContentSettingsService> > factory =
+      LAZY_INSTANCE_INITIALIZER;
+  return factory.Pointer();
+}
+
+void ContentSettingsService::OnExtensionRegistered(
+    const std::string& extension_id,
+    const base::Time& install_time,
+    bool is_enabled) {
+  content_settings_store_->RegisterExtension(
+      extension_id, install_time, is_enabled);
+}
+
+void ContentSettingsService::OnExtensionPrefsLoaded(
+    const std::string& extension_id,
+    const ExtensionPrefs* prefs) {
+  const base::ListValue* content_settings = NULL;
+  if (prefs->ReadPrefAsList(
+          extension_id, pref_names::kPrefContentSettings, &content_settings)) {
+    content_settings_store_->SetExtensionContentSettingFromList(
+        extension_id, content_settings, kExtensionPrefsScopeRegular);
+  }
+  if (prefs->ReadPrefAsList(extension_id,
+                            pref_names::kPrefIncognitoContentSettings,
+                            &content_settings)) {
+    content_settings_store_->SetExtensionContentSettingFromList(
+        extension_id,
+        content_settings,
+        kExtensionPrefsScopeIncognitoPersistent);
+  }
+}
+
+void ContentSettingsService::OnExtensionPrefsDeleted(
+    const std::string& extension_id) {
+  content_settings_store_->UnregisterExtension(extension_id);
+}
+
+void ContentSettingsService::OnExtensionStateChanged(
+    const std::string& extension_id,
+    bool state) {
+  content_settings_store_->SetExtensionState(extension_id, state);
+}
+
+template <>
+void BrowserContextKeyedAPIFactory<
+    ContentSettingsService>::DeclareFactoryDependencies() {
+  DependsOn(ExtensionPrefsFactory::GetInstance());

[James Cook, 2014/04/01 18:45:03]

Does this depend on ExtensionPrefsFactory or the other way around?

[Ken Rockot(use gerrit already), 2014/04/01 21:34:59]

This depends on ExtensionPrefsFactory.

+}
+
+}  // namespace extensions