DevTools: fix CSS.getComputedStyle protocol method

DevTools: fix CSS.getComputedStyle protocol method

Currently, the CSS.getComputedStyle upcasts CSSComputedStyleDeclaration
to the CSSStyleDeclaration and, unwillingly, was using the length() and
item() methods to iterate the CSSComputedStyleDeclaration.

However, these are private methods of CSSComputedStyleDeclaration which
are not supposed to be used by the clients.

BUG=606834
R=dgozman

Committed: https://crrev.com/4e200d9789699ba9d52d8650babb12664b2d1b5d
Cr-Commit-Position: refs/heads/master@{#409418}

[lushnikov, 2016-08-01 18:19:32]

please, take a look

[dgozman, 2016-08-01 18:46:50]

https://codereview.chromium.org/2203473002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector/elements/styles-2/lazy-computed-style-expected.txt
(right):

https://codereview.chromium.org/2203473002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/elements/styles-2/lazy-computed-style-expected.txt:52:
background-repeat-x: ;
Why empty? Is it a valid value?

https://codereview.chromium.org/2203473002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector/elements/styles-3/styles-computed-trace-expected.txt
(left):

https://codereview.chromium.org/2203473002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/elements/styles-3/styles-computed-trace-expected.txt:24:
text-decoration: underline solid rgb(0, 0, 0);
Is this ok?

https://codereview.chromium.org/2203473002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp (left):

https://codereview.chromium.org/2203473002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp:794:
populateAllProperties(properties);
I guess this method is not used anymore?

[lushnikov, 2016-08-01 19:22:39]

https://codereview.chromium.org/2203473002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector/elements/styles-2/lazy-computed-style-expected.txt
(right):

https://codereview.chromium.org/2203473002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/elements/styles-2/lazy-computed-style-expected.txt:52:
background-repeat-x: ;
On 2016/08/01 18:46:49, dgozman wrote:
> Why empty? Is it a valid value?

That's consistent with window.getComputedStyle() method

https://codereview.chromium.org/2203473002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector/elements/styles-3/styles-computed-trace-expected.txt
(left):

https://codereview.chromium.org/2203473002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/elements/styles-3/styles-computed-trace-expected.txt:24:
text-decoration: underline solid rgb(0, 0, 0);
On 2016/08/01 18:46:50, dgozman wrote:
> Is this ok?

Yes, this is a shorthand

https://codereview.chromium.org/2203473002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp (left):

https://codereview.chromium.org/2203473002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp:794:
populateAllProperties(properties);
On 2016/08/01 18:46:50, dgozman wrote:
> I guess this method is not used anymore?

it is used in one more place

[dgozman, 2016-08-01 19:44:46]

lgtm

[lushnikov, 2016-08-01 19:58:00]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2016-08-01 19:58:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 20:43:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-01 20:43:17]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[lushnikov, 2016-08-01 22:59:27]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2016-08-01 22:59:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 23:39:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-01 23:39:33]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[lushnikov, 2016-08-02 00:53:30]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2016-08-02 00:53:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 01:35:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 01:35:04]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[lushnikov, 2016-08-02 03:11:54]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2016-08-02 03:12:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 03:56:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 03:56:11]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[lushnikov, 2016-08-02 15:14:29]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2016-08-02 15:14:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 16:18:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 16:18:28]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[lushnikov, 2016-08-02 19:17:47]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-08-02 19:17:47]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2203473002/#ps20001
(title: "rebaseline")

[commit-bot: I haz the power, 2016-08-02 19:18:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 20:07:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 20:08:00]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[lushnikov, 2016-08-03 00:00:08]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-08-03 00:00:08]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2203473002/#ps40001
(title: "we should not query for descriptors only properties")

[commit-bot: I haz the power, 2016-08-03 00:01:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 01:24:28]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-03 01:26:20]

Description was changed from

==========
DevTools: fix CSS.getComputedStyle protocol method

Currently, the CSS.getComputedStyle upcasts CSSComputedStyleDeclaration
to the CSSStyleDeclaration and, unwillingly, was using the length() and
item() methods to iterate the CSSComputedStyleDeclaration.

However, these are private methods of CSSComputedStyleDeclaration which
are not supposed to be used by the clients.

BUG=606834
R=dgozman
==========

to

==========
DevTools: fix CSS.getComputedStyle protocol method

Currently, the CSS.getComputedStyle upcasts CSSComputedStyleDeclaration
to the CSSStyleDeclaration and, unwillingly, was using the length() and
item() methods to iterate the CSSComputedStyleDeclaration.

However, these are private methods of CSSComputedStyleDeclaration which
are not supposed to be used by the clients.

BUG=606834
R=dgozman

Committed: https://crrev.com/4e200d9789699ba9d52d8650babb12664b2d1b5d
Cr-Commit-Position: refs/heads/master@{#409418}
==========

[commit-bot: I haz the power, 2016-08-03 01:26:22]

Patchset 3 (id:??) landed as
https://crrev.com/4e200d9789699ba9d52d8650babb12664b2d1b5d
Cr-Commit-Position: refs/heads/master@{#409418}