LayoutTests/fast/selectors/input-with-selection-pseudo-element.html - Issue 220343006: Fix for ::selection pseudo element to work on input elements

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/selectors/input-with-selection-pseudo-element.html

Issue 220343006: Fix for ::selection pseudo element to work on input elements (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added Layout Test Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01//EN">
	ojan 2014/04/09 01:57:53 We typically use the html doctype in tests: <!DOCT We typically use the html doctype in tests: <!DOCTYPE html>
	2 <html>

	3 <head>

	4 <title>::selection with input element</title>
	ojan 2014/04/09 01:57:53 No need to include the html, head, body or title e No need to include the html, head, body or title elements. Best to keep the tests as small as possible.
	5 <style>

	6 ::selection { background: green; color:yellow; }
	ojan 2014/04/09 01:57:53 Nit: you need a space after the color:. Nit: you need a space after the color:.
	7 </style>

	8 </head>

	9 <body>

	10 <input id="inputText" type="text" value="Hello" onload="document.execCommand ("SelectAll")"></input>
	ojan 2014/04/09 01:57:53 I don't think inputs have onload events. I don't think inputs have onload events. ojan 2014/04/09 01:57:53 Please use 4 space indents. Please use 4 space indents.
	11 <br>The above selected text in the input box should have green background an d yellow color.

	12 </body>

	13 <script type="text/javascript">
	ojan 2014/04/09 01:57:53 No need to include a type on script elements. No need to include a type on script elements.
	14 window.onload = document.getElementById('inputText').select();

	15 </script>
	ojan 2014/04/09 01:57:53 This test should be done as a reftest so that you This test should be done as a reftest so that you don't need platform specific pngs. Reftests are tests that have a -expected.html file that renders the same way instead of having -expected.txt/png files. deepak.sa 2014/04/09 14:01:07 As for RefTests, we have to create our own expecte Show quoted text On 2014/04/09 01:57:53, ojan wrote: > This test should be done as a reftest so that you don't need platform specific > pngs. Reftests are tests that have a -expected.html file that renders the same > way instead of having -expected.txt/png files. As for RefTests, we have to create our own expected html. IMHO, it is not possible to create same effect of selection background & color in case of input element. Other RefTests that have been written for selection pseudo element, is only for textual selection in <p> or similar tags. The way they have written the expected html is setting the background color, which gives the same behaviour as selecting the text. But incase of input element, selection and background gives different behaviour because selection sets background on div(#inner-editor) inside the input. If there is any other way of creating the RefTest, please let me know. Thanks.
	16 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/selectors/input-with-selection-pseudo-element-expected.txt » ('j') | Source/core/rendering/RenderObject.cpp » ('J')