Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2203393002: Resolve conflict in exo/wayland/server.cc in m53 branch (Closed)

Created:
4 years, 4 months ago by oshima
Modified:
4 years, 4 months ago
Reviewers:
hidehiko
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Resolve conflict in exo/wayland/server.cc in m53 branch The method OnDisplayWorkareInsetsChanged has been removed on ToT, so this method wasn't updated in the original CL. BUG=632083 TBR=hidehiko@chromium.org Cr-Commit-Position: refs/branch-heads/2785@{#484} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/9f38962edfcc46c2dc91b426ce24fa43993529cc/components/exo/wayland/server.cc Committed: https://chromium.googlesource.com/chromium/src/+/9a9853c91d1c2cb9ac862373603b1304859a6e35

Patch Set 1 #

Total comments: 1

Patch Set 2 : Resolve conflict #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M components/exo/wayland/server.cc View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
oshima
4 years, 4 months ago (2016-08-03 14:04:17 UTC) #6
hidehiko
https://codereview.chromium.org/2203393002/diff/1/components/exo/wayland/server.cc File components/exo/wayland/server.cc (right): https://codereview.chromium.org/2203393002/diff/1/components/exo/wayland/server.cc#newcode1621 components/exo/wayland/server.cc:1621: SendConfigure_DEPRECATED(); Maybe: SendConfigure_DEPRECATED(primary); ?
4 years, 4 months ago (2016-08-03 18:11:32 UTC) #8
oshima
On 2016/08/03 18:11:32, hidehiko wrote: > https://codereview.chromium.org/2203393002/diff/1/components/exo/wayland/server.cc > File components/exo/wayland/server.cc (right): > > https://codereview.chromium.org/2203393002/diff/1/components/exo/wayland/server.cc#newcode1621 > ...
4 years, 4 months ago (2016-08-03 22:39:05 UTC) #9
oshima
4 years, 4 months ago (2016-08-03 22:45:41 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
9a9853c91d1c2cb9ac862373603b1304859a6e35 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698