Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2203353002: [api] Stay in C++ when constructing an API-function (Closed)

Created:
4 years, 4 months ago by Camillo Bruni
Modified:
4 years, 4 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[api] Stay in C++ when constructing an API-function This CL applies the same optimization already present for calling API-function. Execution::New and Execution::Call now both check whether the target is an API-function and avoid calling out into the construct/call stub. BUG=chromium:630217 Committed: https://crrev.com/b920d5f3ff33e8202f3218521c8335723d384e03 Cr-Commit-Position: refs/heads/master@{#38433}

Patch Set 1 #

Total comments: 1

Patch Set 2 : moving stack overflow check #

Patch Set 3 : fix non-constructor path #

Patch Set 4 : set the receiver to the_hole for construct calls #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -32 lines) Patch
M src/builtins/builtins.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/builtins/builtins-api.cc View 1 2 3 3 chunks +11 lines, -6 lines 0 comments Download
M src/execution.cc View 1 2 3 2 chunks +24 lines, -20 lines 0 comments Download
M src/objects.cc View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
Camillo Bruni
PTAL
4 years, 4 months ago (2016-08-03 12:48:41 UTC) #2
Toon Verwaest
lgtm https://codereview.chromium.org/2203353002/diff/1/src/execution.cc File src/execution.cc (right): https://codereview.chromium.org/2203353002/diff/1/src/execution.cc#newcode63 src/execution.cc:63: if (target->IsJSFunction() && Move this below the stackoverflow ...
4 years, 4 months ago (2016-08-04 12:31:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2203353002/20001
4 years, 4 months ago (2016-08-04 13:01:58 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/builds/1717) v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 4 months ago (2016-08-04 13:15:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2203353002/60001
4 years, 4 months ago (2016-08-08 11:13:56 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-08 11:16:20 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 11:17:01 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b920d5f3ff33e8202f3218521c8335723d384e03
Cr-Commit-Position: refs/heads/master@{#38433}

Powered by Google App Engine
This is Rietveld 408576698