Source/web/WebViewImpl.cpp - Issue 220333003: Apply OwnPtr|PassOwnPtr to handle member variables and arguments in MIDIClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebViewImpl.cpp

Issue 220333003: Apply OwnPtr|PassOwnPtr to handle member variables and arguments in MIDIClient (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix a unit test #2 Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebViewImpl.cpp

diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp

index 7b8480af59be4c5b1c36fac0e1b637f4b99c79b2..4dbb28f09e84cb73db9682bc3a37649d8a3d3c58 100644

--- a/Source/web/WebViewImpl.cpp

+++ b/Source/web/WebViewImpl.cpp

@@ -361,7 +361,6 @@ WebViewImpl::WebViewImpl(WebViewClient* client)

, m_recreatingGraphicsContext(false)

, m_geolocationClientProxy(adoptPtr(new GeolocationClientProxy(client ? client->geolocationClient() : 0)))

, m_userMediaClientImpl(this)

- , m_midiClientProxy(adoptPtr(new MIDIClientProxy(client ? client->webMIDIClient() : 0)))

, m_flingModifier(0)

, m_flingSourceDevice(false)

, m_fullscreenController(FullscreenController::create(this))

@@ -387,7 +386,7 @@ WebViewImpl::WebViewImpl(WebViewClient* client)

m_page = adoptPtr(new Page(pageClients));

provideUserMediaTo(*m_page, &m_userMediaClientImpl);

MediaKeysController::provideMediaKeysTo(*m_page, &m_mediaKeysClientImpl);

- provideMIDITo(*m_page, m_midiClientProxy.get());

+ provideMIDITo(*m_page, MIDIClientProxy::create(client ? client->webMIDIClient() : 0));

#if ENABLE(INPUT_SPEECH)

provideSpeechInputTo(*m_page, SpeechInputClientImpl::create(client));

#endif

« Source/modules/webmidi/MIDIController.cpp ('K') | « Source/web/MIDIClientProxy.h ('k') | no next file » | no next file with comments »