Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: Source/web/MIDIClientProxy.cpp

Issue 220333003: Apply OwnPtr|PassOwnPtr to handle member variables and arguments in MIDIClient (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/MIDIClientProxy.h ('k') | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/MIDIClientProxy.cpp
diff --git a/Source/web/MIDIClientProxy.cpp b/Source/web/MIDIClientProxy.cpp
index a85f91e8e15f8c661a7099443b850d3075e0c5b0..abcdf7e03bb2a343a73a64b7f3f8973fdc8aef7e 100644
--- a/Source/web/MIDIClientProxy.cpp
+++ b/Source/web/MIDIClientProxy.cpp
@@ -44,6 +44,11 @@ MIDIClientProxy::MIDIClientProxy(WebMIDIClient* client)
{
}
+PassOwnPtr<MIDIClientProxy> MIDIClientProxy::create(WebMIDIClient* client)
+{
+ return adoptPtr(new MIDIClientProxy(client));
jochen (gone - plz use gerrit) 2014/04/02 09:28:59 nit should go into the header
+}
+
void MIDIClientProxy::requestSysexPermission(PassRefPtrWillBeRawPtr<MIDIAccess> access)
{
if (m_client)
haraken 2014/04/02 01:08:54 Is it possible that m_client is 0?
gyuyoung-inactive 2014/04/02 01:17:35 Yes, client parameter of WebViewImpl's ctor can be
« no previous file with comments | « Source/web/MIDIClientProxy.h ('k') | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698