Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2203323002: Remove media_unittests. (Closed)

Created:
4 years, 4 months ago by ehmaldonado_chromium
Modified:
4 years, 4 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Remove media_unittests. The entry doesn't apply anymore, since VideoCaptureDeviceTest* was moved to capture_unittests. BUG=618718 Committed: https://chromium.googlesource.com/chromium/tools/build/+/4caf780db33469b8003353ec6443e46c4722f65d

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add media_unittests' flags to capture_unittests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -319 lines) Patch
M scripts/slave/recipe_modules/chromium_tests/chromium_webrtc.py View 1 1 chunk +3 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Linux_Builder.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Linux_Tester.json View 1 2 chunks +5 lines, -35 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Mac_Builder.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Mac_Tester.json View 1 2 chunks +5 lines, -34 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Win10_Tester.json View 1 2 chunks +5 lines, -34 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Win7_Tester.json View 1 2 chunks +5 lines, -34 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Win8_Tester.json View 1 2 chunks +5 lines, -34 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Win_Builder.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Linux_Builder.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Linux_Tester.json View 1 2 chunks +5 lines, -35 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Mac_Builder.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Mac_Tester.json View 1 2 chunks +5 lines, -34 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Win10_Tester.json View 1 2 chunks +5 lines, -34 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Win7_Tester.json View 1 2 chunks +5 lines, -34 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Win_Builder.json View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
ehmaldonado_chromium
4 years, 4 months ago (2016-08-03 11:13:49 UTC) #3
kjellander_chromium
Please add the flags I mentioned in the comment to the capture_unittests invocation. https://codereview.chromium.org/2203323002/diff/1/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc.py File ...
4 years, 4 months ago (2016-08-03 11:20:22 UTC) #4
ehmaldonado_chromium
ptal https://codereview.chromium.org/2203323002/diff/1/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc.py File scripts/slave/recipe_modules/chromium_tests/chromium_webrtc.py (left): https://codereview.chromium.org/2203323002/diff/1/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc.py#oldcode132 scripts/slave/recipe_modules/chromium_tests/chromium_webrtc.py:132: '--test-launcher-jobs=1', On 2016/08/03 11:20:22, kjellander_chromium wrote: > To ...
4 years, 4 months ago (2016-08-03 11:31:22 UTC) #5
kjellander_chromium
lgtm
4 years, 4 months ago (2016-08-03 11:38:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2203323002/20001
4 years, 4 months ago (2016-08-03 11:38:43 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 11:45:44 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/4caf780db33469b80033...

Powered by Google App Engine
This is Rietveld 408576698