[system-health] Re-enable non-verbose logging in System Health memory benchmarks

tools/perf/benchmarks/system_health_smoke_test.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Run all system health stories used by system health benchmarks.
 
 Only memory benchmarks are used when running these stories to make the total
 cycle time manageable. Other system health benchmarks should be using the same
 stories as memory ones, only with fewer actions (no memory dumping).
 """
@@ skipping 88 matching lines @@
   benchmark_class.AddCommandLineArgs(parser)
   benchmark_module.AddCommandLineArgs(parser)
   benchmark_class.SetArgumentDefaults(parser)
   options.MergeDefaultValues(parser.get_default_values())
 
   benchmark_class.ProcessCommandLineArgs(None, options)
   benchmark_module.ProcessCommandLineArgs(None, options)
   # Only measure a single story so that this test cycles reasonably quickly.
   options.pageset_repeat = 1
   options.page_repeat = 1
-  # Enable browser logging in the smoke test only (crbug.com/625172).
-  options.logging_verbosity = 'non-verbose'

[nednguyen, 2016/08/03 12:31:13]

Why remove the log here? These are convenient for diagnosing the failure if any
of the test fails.

[petrcermak, 2016/08/03 13:05:35]

No need to do it here when SetExtraBrowserOptions above would do it.

[nednguyen, 2016/08/03 13:13:26]

I see.

   return options
 
 
 def load_tests(loader, standard_tests, pattern):
   del loader, standard_tests, pattern  # unused
   suite = progress_reporter.TestSuite()
   benchmark_classes = GetSystemHealthBenchmarksToSmokeTest()
   assert benchmark_classes, 'This list should never be empty'
   for benchmark_class in benchmark_classes:
 
     # HACK: these options should be derived from options_for_unittests which are
     # the resolved options from run_tests' arguments. However, options is only
     # parsed during test time which happens after load_tests are called.
     # Since none of our system health benchmarks creates stories based on
     # command line options, it should be ok to pass options=None to
     # CreateStorySet.
     for story_to_smoke_test in (
         benchmark_class().CreateStorySet(options=None).stories):
       suite.addTest(
           _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test))
 
   return suite