Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2203283003: Require gn format in presubmit (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
jcgregorio, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : nicer errors #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -6 lines) Patch
M BUILD.gn View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M PRESUBMIT.py View 1 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
mtklein_C
4 years, 4 months ago (2016-08-03 20:24:48 UTC) #3
jcgregorio
lgtm
4 years, 4 months ago (2016-08-03 20:38:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2203283003/20001
4 years, 4 months ago (2016-08-03 20:53:02 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot/builds/5383) Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on master.client.skia.compile (JOB_FAILED, ...
4 years, 4 months ago (2016-08-03 20:54:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2203283003/40001
4 years, 4 months ago (2016-08-03 20:59:21 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 21:18:26 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/4db3b7969f62f5ddbf32bd812b9510af018ece89

Powered by Google App Engine
This is Rietveld 408576698