Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2701)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/share/ShareUrlTest.java

Issue 2203273002: navigator.share: Resolve promise only after user chooses a target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Null-check callback. Fixes crbug.com/637194. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImpl.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/javatests/src/org/chromium/chrome/browser/share/ShareUrlTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/share/ShareUrlTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/share/ShareUrlTest.java
index b2ace64d8330403606f146a18f12a1908408613c..ba4ddcb678ce0ddd1229a62ac859da372b020dac 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/share/ShareUrlTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/share/ShareUrlTest.java
@@ -25,7 +25,7 @@ public class ShareUrlTest extends NativeLibraryTestBase {
}
private void assertCorrectUrl(String originalUrl, String sharedUrl) {
- Intent intent = ShareHelper.getShareIntent(new Activity(), "", sharedUrl, null);
+ Intent intent = ShareHelper.getShareIntent(new Activity(), "", "", sharedUrl, null);
assert (intent.hasExtra(Intent.EXTRA_TEXT));
String url = intent.getStringExtra(Intent.EXTRA_TEXT);
assertEquals(originalUrl, url);
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImpl.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698