chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java - Issue 2203273002: navigator.share: Resolve promise only after user chooses a target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Issue 2203273002: navigator.share: Resolve promise only after user chooses a target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Null-check callback. Fixes crbug.com/637194. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

index 30ce9023abd926085a0c060a8b68541a92ad201c..22553bd67afaa904db916040230234e1cbbab4e8 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

@@ -1005,8 +1005,8 @@ public abstract class ChromeActivity extends AsyncInitializationActivity

// URL directly.

if (url == null) url = currentTab.getUrl();

- ShareHelper.share(

- shareDirectly, mainActivity, currentTab.getTitle(), url, bitmap);

+ ShareHelper.share(shareDirectly, true, mainActivity, currentTab.getTitle(),

+ null, url, bitmap, null);

if (shareDirectly) {

RecordUserAction.record("MobileMenuDirectShare");

} else {

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java » ('j') | no next file with comments »