Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Side by Side Diff: chrome/browser/resources/history/externs.js

Issue 2203263002: History: Add load-time metric for non-MD and MD History WebUI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview Externs for objects sent from C++ to chrome://history. 6 * @fileoverview Externs for objects sent from C++ to chrome://history.
7 * @externs 7 * @externs
8 */ 8 */
9 9
10 /** 10 /**
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 * chrome/browser/ui/webui/foreign_session_handler.cc: 68 * chrome/browser/ui/webui/foreign_session_handler.cc:
69 * @typedef {{collapsed: boolean, 69 * @typedef {{collapsed: boolean,
70 * deviceType: string, 70 * deviceType: string,
71 * name: string, 71 * name: string,
72 * modifiedTime: string, 72 * modifiedTime: string,
73 * tag: string, 73 * tag: string,
74 * timestamp: number, 74 * timestamp: number,
75 * windows: Array<ForeignSessionWindow>}} 75 * windows: Array<ForeignSessionWindow>}}
76 */ 76 */
77 var ForeignSession; 77 var ForeignSession;
78
79 // Other externs required to compile history:
80
81 var performance = {};
82
83 /**
84 * @return {number}
85 */
86 performance.now = function() {};
Dan Beam 2016/08/03 21:05:17 i haz a sad https://github.com/google/closure-comp
tsergeant 2016/08/03 22:53:56 Is there any particular reason why these aren't pu
Dan Beam 2016/08/04 03:51:33 it should be. have you tried window.performance.no
tsergeant 2016/08/04 03:59:06 Ah, that works 🙌 (that doesn't show up in a code
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/history/history.js » ('j') | chrome/browser/resources/history/history.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698