Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2203233002: Revert of Add EncodedImageCallback::OnEncodedImage(). (Closed)

Created:
4 years, 4 months ago by Sergey Ulanov
Modified:
4 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, tterriberry_mozilla.com, qiang.lu, peah-webrtc, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Add EncodedImageCallback::OnEncodedImage(). (patchset #14 id:300001 of https://codereview.chromium.org/2089773002/ ) Reason for revert: broke browser_tests Original issue's description: > Add EncodedImageCallback::OnEncodedImage(). > > OnEncodedImage() is going to replace Encoded(), which is deprecated now. > The new OnEncodedImage() returns Result struct that contains frame_id, > which tells the encoder RTP timestamp for the frame. > > BUG=chromium:621691 > R=niklas.enbom@webrtc.org, sprang@webrtc.org, stefan@webrtc.org > > Committed: https://crrev.com/4c7f4cd2ef76821edca6d773d733a924b0bedd25 > Committed: https://crrev.com/ad34dbe934d47f88011045671b4aea00dbd5a795 > Cr-Original-Commit-Position: refs/heads/master@{#13613} > Cr-Commit-Position: refs/heads/master@{#13615} TBR=pbos@webrtc.org,mflodman@webrtc.org,sprang@webrtc.org,stefan@webrtc.org,niklas.enbom@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:621691 Committed: https://crrev.com/51db4dd1bdf81dcd8cd1ced5dbad8807834611e4 Cr-Commit-Position: refs/heads/master@{#13616}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+388 lines, -483 lines) Patch
M webrtc/modules/rtp_rtcp/include/rtp_rtcp.h View 2 chunks +3 lines, -23 lines 0 comments Download
M webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h View 1 chunk +9 lines, -10 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/nack_rtx_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h View 1 chunk +9 lines, -9 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc View 1 chunk +8 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.h View 3 chunks +20 lines, -21 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 8 chunks +35 lines, -42 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_audio.h View 2 chunks +7 lines, -7 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_audio.cc View 10 chunks +32 lines, -32 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc View 17 chunks +57 lines, -57 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_video.h View 1 chunk +9 lines, -9 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc View 4 chunks +26 lines, -25 lines 0 comments Download
M webrtc/modules/rtp_rtcp/test/testAPI/test_api_audio.cc View 4 chunks +11 lines, -15 lines 0 comments Download
M webrtc/modules/rtp_rtcp/test/testAPI/test_api_rtcp.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/test/testAPI/test_api_video.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.h View 1 chunk +4 lines, -5 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h View 4 chunks +19 lines, -25 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/vp8_sequence_coder.cc View 3 chunks +6 lines, -8 lines 0 comments Download
M webrtc/modules/video_coding/generic_encoder.h View 1 chunk +3 lines, -4 lines 0 comments Download
M webrtc/modules/video_coding/generic_encoder.cc View 2 chunks +8 lines, -11 lines 0 comments Download
M webrtc/modules/video_coding/include/mock/mock_video_codec_interface.h View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/modules/video_coding/video_coding_impl.cc View 2 chunks +8 lines, -10 lines 0 comments Download
M webrtc/modules/video_coding/video_sender_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/test/fake_encoder.h View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/test/fake_encoder.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M webrtc/video/payload_router.h View 2 chunks +5 lines, -6 lines 0 comments Download
M webrtc/video/payload_router.cc View 2 chunks +9 lines, -16 lines 0 comments Download
M webrtc/video/payload_router_unittest.cc View 8 chunks +14 lines, -13 lines 0 comments Download
M webrtc/video/video_encoder_unittest.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M webrtc/video/video_receive_stream.h View 1 chunk +3 lines, -4 lines 0 comments Download
M webrtc/video/video_receive_stream.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/video/video_send_stream.h View 1 chunk +3 lines, -4 lines 0 comments Download
M webrtc/video/video_send_stream.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M webrtc/video/vie_encoder.h View 1 chunk +3 lines, -4 lines 0 comments Download
M webrtc/video/vie_encoder.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M webrtc/video_encoder.h View 1 chunk +2 lines, -38 lines 0 comments Download
M webrtc/voice_engine/channel.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Sergey Ulanov
Created Revert of Add EncodedImageCallback::OnEncodedImage().
4 years, 4 months ago (2016-08-03 00:33:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2203233002/1
4 years, 4 months ago (2016-08-03 00:33:26 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 00:33:47 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 00:33:52 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/51db4dd1bdf81dcd8cd1ced5dbad8807834611e4
Cr-Commit-Position: refs/heads/master@{#13616}

Powered by Google App Engine
This is Rietveld 408576698