Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 220323005: Revert of Add a whole-app-list unit test. (Closed)

Created:
6 years, 8 months ago by tkent
Modified:
6 years, 8 months ago
Reviewers:
tapted, calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Visibility:
Public.

Description

Revert of Add a whole-app-list unit test. (https://codereview.chromium.org/210083009/) Reason for revert: Broke Linux build. http://build.chromium.org/p/chromium.linux/builders/Linux%20Builder/builds/29124/steps/compile/logs/stdio ../../ui/app_list/views/app_list_view_unittest.cc:9:39: fatal error: base/strings/string_util.h.: No such file or directory Original issue's description: > Add a whole-app-list unit test. > > This establishes a test harness for doing tests that touch on multiple > parts of the app launcher UI, or that need coverage for the various app > launcher configurations: Ash or Desktop; regular or experimental > "landscape" mode. > > It currently just tests displaying and closing the app launcher in its > default state with a flat (no folders), 2- or 3-page model. > > BUG=169114 > TEST=Added unit tests AppListViewTest{Aura,Desktop}.* > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260762 TBR=calamity@chromium.org,tapted@chromium.org NOTREECHECKS=true NOTRY=true BUG=169114 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260769

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -271 lines) Patch
M chrome/browser/ui/views/app_list/win/app_list_service_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/app_list.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ui/app_list/views/app_list_view.h View 2 chunks +1 line, -2 lines 0 comments Download
M ui/app_list/views/app_list_view.cc View 3 chunks +5 lines, -6 lines 0 comments Download
D ui/app_list/views/app_list_view_unittest.cc View 1 chunk +0 lines, -261 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tkent
Created Revert of Add a whole-app-list unit test.
6 years, 8 months ago (2014-04-01 03:36:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/220323005/1
6 years, 8 months ago (2014-04-01 03:36:35 UTC) #2
commit-bot: I haz the power
Change committed as 260769
6 years, 8 months ago (2014-04-01 03:37:50 UTC) #3
tapted
6 years, 8 months ago (2014-04-01 03:58:35 UTC) #4
Message was sent while issue was closed.
lgtm - thanks. And wow. How is this not an error no the microsoft compiler o_O?
-- win_rel compiled & ran all this fine. Filed http://crbug.com/356044 for the
bigger issue.

Powered by Google App Engine
This is Rietveld 408576698