device/bluetooth: Rename device::bluetooth_utils::UUID to device::BluetoothUUID

device/bluetooth: Rename device::bluetooth_utils::UUID to device::BluetoothUUID

Moved bluetooth_utils::UUID into its own file called bluetooth_uuid.h/cc as
class BluetoothUUID. This effectively removes the usage of
bluetooth_utils::CanonicalUuid

BUG=358874
TEST=device_unittests, browser_tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261566

[keybuk, 2014-04-01 17:12:09]

also replace the vector of string uuids in BluetoothDevice with BluetoothUUID

https://codereview.chromium.org/220323004/diff/1/device/bluetooth/bluetooth_u...
File device/bluetooth/bluetooth_utils.h (right):

https://codereview.chromium.org/220323004/diff/1/device/bluetooth/bluetooth_u...
device/bluetooth/bluetooth_utils.h:25: std::string CanonicalUuid(std::string
uuid);
Since you're touching all the files anyway, let's remove this file and function
and go full BluetoothUUID

[armansito, 2014-04-01 23:42:49]

mkearney@: chrome/common/extensions/*
rpaquay@: FYI

[armansito, 2014-04-02 20:08:23]

tengs@: FYI

[armansito, 2014-04-02 21:37:35]

miket@: PTAL at chrome/browser/extensions/*

[miket_OOO, 2014-04-02 21:42:15]

On 2014/04/02 21:37:35, armansito wrote:
> miket@: PTAL at chrome/browser/extensions/*

c/b/e/ LGTM

[keybuk, 2014-04-02 23:32:27]

lgtm

https://codereview.chromium.org/220323004/diff/40001/chrome/browser/extension...
File chrome/browser/extensions/api/bluetooth/bluetooth_apitest.cc (right):

https://codereview.chromium.org/220323004/diff/40001/chrome/browser/extension...
chrome/browser/extensions/api/bluetooth/bluetooth_apitest.cc:648:
uuids.push_back(BluetoothUUID("0x1106"));
nit: the canonical format for a 16-bit UUID is "1105" and is what value() would
return for this BluetoothUUID object. There's no need to test conversion here
since you have BluetoothUUID unit tests that do that - so why not use the
Canonical 16-bit form everywhere?

(repeat nit every time you did this :p)

[armansito, 2014-04-03 00:44:35]

https://codereview.chromium.org/220323004/diff/40001/chrome/browser/extension...
File chrome/browser/extensions/api/bluetooth/bluetooth_apitest.cc (right):

https://codereview.chromium.org/220323004/diff/40001/chrome/browser/extension...
chrome/browser/extensions/api/bluetooth/bluetooth_apitest.cc:648:
uuids.push_back(BluetoothUUID("0x1106"));
On 2014/04/02 23:32:27, keybuk wrote:
> nit: the canonical format for a 16-bit UUID is "1105" and is what value()
would
> return for this BluetoothUUID object. There's no need to test conversion here
> since you have BluetoothUUID unit tests that do that - so why not use the
> Canonical 16-bit form everywhere?
> 
> (repeat nit every time you did this :p)

Done.

[armansito, 2014-04-03 00:44:39]

The CQ bit was checked by armansito@chromium.org

[commit-bot: I haz the power, 2014-04-03 00:45:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/armansito@chromium.org/220323004/60001

[commit-bot: I haz the power, 2014-04-03 01:49:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-03 01:49:53]

Retried try job too often on win_rel for step(s) base_unittests, browser_tests,
interactive_ui_tests, net_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_compile_dbg

[armansito, 2014-04-03 08:52:27]

The CQ bit was checked by armansito@chromium.org

[commit-bot: I haz the power, 2014-04-03 08:52:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/armansito@chromium.org/220323004/130001

[commit-bot: I haz the power, 2014-04-03 09:37:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-03 09:37:28]

Retried try job too often on win_rel for step(s) app_list_unittests,
ash_unittests, aura_unittests, cacheinvalidation_unittests, cc_unittests,
check_deps, check_deps2git, chrome_elf_unittests, chromedriver_unittests,
components_unittests, compositor_unittests, content_browsertests,
content_unittests, crypto_unittests, events_unittests, gfx_unittests,
google_apis_unittests, gpu_unittests, installer_util_unittests, ipc_tests,
jingle_unittests, media_unittests, mini_installer_test, nacl_integration,
ppapi_unittests, printing_unittests, remoting_unittests, sql_unittests,
sync_integration_tests, sync_unit_tests, telemetry_perf_unittests,
telemetry_unittests, views_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[armansito, 2014-04-03 21:07:27]

The CQ bit was checked by armansito@chromium.org

[commit-bot: I haz the power, 2014-04-03 21:08:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/armansito@chromium.org/220323004/160001

[commit-bot: I haz the power, 2014-04-03 23:07:30]

Change committed as 261566