Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 2203213003: Properly pass InitializationFlag back from ScriptContextTable lookups (Closed)

Created:
4 years, 4 months ago by adamk
Modified:
4 years, 4 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Properly pass InitializationFlag back from ScriptContextTable lookups This was dropped accidentally in bb97d27ab. R=verwaest@chromium.org BUG=chromium:633884 Committed: https://crrev.com/e6d2c9b58416d87d874cba02bccedb3b3d53ed41 Cr-Commit-Position: refs/heads/master@{#38345}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M src/contexts.cc View 1 chunk +1 line, -0 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-633884.js View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
adamk
4 years, 4 months ago (2016-08-03 20:33:43 UTC) #1
Toon Verwaest
oops. blarg ;) lgtm
4 years, 4 months ago (2016-08-04 12:32:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2203213003/1
4 years, 4 months ago (2016-08-04 16:09:10 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-04 16:10:53 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 16:13:52 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e6d2c9b58416d87d874cba02bccedb3b3d53ed41
Cr-Commit-Position: refs/heads/master@{#38345}

Powered by Google App Engine
This is Rietveld 408576698