Add new bench for occluded blurmaskfilter draws

Add new bench for occluded blurmaskfilter draws


w/ occluders
  44/44  MB     6       497us   500us   500us   502us   0%      .oOOooooOO      gpu     bluroccludedrrect

w/o occluders
  41/41  MB     5       1.08ms  1.09ms  1.12ms  1.47ms  11%     .........O      gpu     bluroccludedrrect


GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2203153002

Committed: https://skia.googlesource.com/skia/+/276d3286b32900d8b7e895c5224ceba1922d2391

[robertphillips, 2016-08-02 19:18:58]

Description was changed from

==========
Add new bench for occluded blurmaskfilter draws
==========

to

==========
Add new bench for occluded blurmaskfilter draws
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2203153002
==========

[robertphillips, 2016-08-02 19:19:23]

Description was changed from

==========
Add new bench for occluded blurmaskfilter draws
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2203153002
==========

to

==========
Add new bench for occluded blurmaskfilter draws
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2203153002
==========

[robertphillips, 2016-08-02 19:19:23]

robertphillips@google.com changed reviewers:
+ reed@google.com

[robertphillips, 2016-08-02 19:35:06]

Description was changed from

==========
Add new bench for occluded blurmaskfilter draws
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2203153002
==========

to

==========
Add new bench for occluded blurmaskfilter draws


w/ occluders
  44/44  MB     6       497us   500us   500us   502us   0%      .oOOooooOO     
gpu     bluroccludedrrect

w/o occluders
  41/41  MB     5       1.08ms  1.09ms  1.12ms  1.47ms  11%     .........O     
gpu     bluroccludedrrect


GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2203153002
==========

[robertphillips, 2016-08-03 17:52:45]

PTAL. I think we can land this w/o having to decide on how occluders are
implemented.

[reed1, 2016-08-03 20:16:19]

lgtm

https://codereview.chromium.org/2203153002/diff/40001/bench/BlurOccludedRRect...
File bench/BlurOccludedRRectBench.cpp (right):

https://codereview.chromium.org/2203153002/diff/40001/bench/BlurOccludedRRect...
bench/BlurOccludedRRectBench.cpp:25: static SkRect
compute_central_occluder(const SkRRect& rr) {
This could be checked in centrally (but perhaps still privately) as a RRect
utility...?

[robertphillips, 2016-08-04 14:42:57]

robertphillips@google.com changed reviewers:
+ jvanverth@google.com

[robertphillips, 2016-08-04 14:49:55]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[robertphillips, 2016-08-04 14:49:58]

https://codereview.chromium.org/2203153002/diff/40001/bench/BlurOccludedRRect...
File bench/BlurOccludedRRectBench.cpp (right):

https://codereview.chromium.org/2203153002/diff/40001/bench/BlurOccludedRRect...
bench/BlurOccludedRRectBench.cpp:25: static SkRect
compute_central_occluder(const SkRRect& rr) {
On 2016/08/03 20:16:18, reed1 wrote:
> This could be checked in centrally (but perhaps still privately) as a RRect
> utility...?

Done.

[commit-bot: I haz the power, 2016-08-04 14:50:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 14:53:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 14:53:34]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-Clang-x86_64-Debug-GN-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)
  Build-Ubuntu-GCC-x86_64-Release-GN-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[robertphillips, 2016-08-04 15:20:17]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 15:20:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 15:52:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 15:52:08]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-08-04 16:01:58]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2016-08-04 16:01:58]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/2203153002/#ps80001
(title: "Appease compilers")

[commit-bot: I haz the power, 2016-08-04 16:02:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 16:03:26]

Description was changed from

==========
Add new bench for occluded blurmaskfilter draws


w/ occluders
  44/44  MB     6       497us   500us   500us   502us   0%      .oOOooooOO     
gpu     bluroccludedrrect

w/o occluders
  41/41  MB     5       1.08ms  1.09ms  1.12ms  1.47ms  11%     .........O     
gpu     bluroccludedrrect


GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2203153002
==========

to

==========
Add new bench for occluded blurmaskfilter draws


w/ occluders
  44/44  MB     6       497us   500us   500us   502us   0%      .oOOooooOO     
gpu     bluroccludedrrect

w/o occluders
  41/41  MB     5       1.08ms  1.09ms  1.12ms  1.47ms  11%     .........O     
gpu     bluroccludedrrect


GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2203153002

Committed:
https://skia.googlesource.com/skia/+/276d3286b32900d8b7e895c5224ceba1922d2391
==========

[commit-bot: I haz the power, 2016-08-04 16:03:27]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/276d3286b32900d8b7e895c5224ceba1922d2391