chromecast/crash/linux/crash_util.cc - Issue 2203123003: [Chromecast] Remove usage of nonreentrant functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/crash/linux/crash_util.cc

Issue 2203123003: [Chromecast] Remove usage of nonreentrant functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: slan@ comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromecast/crash/linux/crash_util.cc

diff --git a/chromecast/crash/linux/crash_util.cc b/chromecast/crash/linux/crash_util.cc

index 396fd84481e8d9e6bec6f6d06c552d312fc672cc..01b29202f3d7b98eba0537aa4de5724f8201acd1 100644

--- a/chromecast/crash/linux/crash_util.cc

+++ b/chromecast/crash/linux/crash_util.cc

@@ -67,7 +67,6 @@ bool CrashUtil::RequestUploadCrashDump(

new MinidumpWriter(&minidump_generator, filename.value(), params));

}

bool success = false;

- writer->set_non_blocking(false);

success = (0 == writer->Write()); // error already logged.

// In case the file is still in $TEMP, remove it. Note that DeleteFile() will

« no previous file with comments | « chromecast/crash/linux/crash_testing_utils.cc ('k') | chromecast/crash/linux/dump_info.h » ('j') | no next file with comments »