[Chromecast] Remove usage of nonreentrant functions.

chromecast/base/file_utils.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chromecast/base/file_utils.h"
+
+#include <errno.h>
+#include <fcntl.h>
+#include <sys/file.h>
+
+namespace {
+
+bool AttemptLockOnFileWithFlag(const char* file, int flag) {

[bcf, 2016/08/03 20:45:10]

nit: pass in const base::FilePath& so you only have to call .value().c_str()
once.

[ameyak, 2016/08/04 15:25:30]

Done.

+  int fd;
+  if ((fd = open(file, O_RDONLY)) < 0) {
+    LOG(ERROR) << "Error opening " << file << " error = " << strerror(errno);
+    return false;
+  }
+
+  flag = TEMP_FAILURE_RETRY(flock(fd, flag));

[bcf, 2016/08/03 20:45:10]

Should log on error.

[bcf, 2016/08/03 20:45:10]

You shouldn't reuse this variable for another purpose. Just use

int ret = TEMP_FAILURE_RETRY(flock(fd, flag));

[ameyak, 2016/08/04 15:25:30]

Done.

[ameyak, 2016/08/04 15:25:30]

Done.

+  close(fd);
+  return !flag;
+}
+
+}  // namespace
+
+namespace chromecast {
+
+bool LockFile(const base::FilePath& path) {
+  return AttemptLockOnFileWithFlag(path.value().c_str(), LOCK_EX);
+}
+
+bool UnlockFile(const base::FilePath& path) {
+  return AttemptLockOnFileWithFlag(path.value().c_str(), LOCK_UN);
+}
+
+}  // namspace chromecast