chromecast/base/file_utils.h - Issue 2203123003: [Chromecast] Remove usage of nonreentrant functions.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chromecast/base/file_utils.h

Issue 2203123003: [Chromecast] Remove usage of nonreentrant functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: synchronized_minidump_manager changes Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROMECAST_BASE_FILE_UTILS_H_

	6 #define CHROMECAST_BASE_FILE_UTILS_H_

	7

	8 #include "base/files/file_path.h"

	9

	10 namespace chromecast {

	11

	12 // Used for locking/unlocking files. This is a blocking request. If the methods
	bcf 2016/08/03 02:40:23 Super nit: These aren't technically methods since Super nit: These aren't technically methods since they aren't class members. ameyak 2016/08/03 18:50:32 Done. Technically correct is the best kind of corr Show quoted text On 2016/08/03 02:40:23, bcf wrote: > Super nit: These aren't technically methods since they aren't class members. Done. Technically correct is the best kind of correct. :)
	13 // fail, this indicates that either the file specified by \|path\| does not exist,

	14 // or the locking procedure failed.

	15 bool LockFile(const base::FilePath& path);

	16 bool UnlockFile(const base::FilePath& path);

	17

	18 } // namespace chromecast

	19

	20 #endif // CHROMECAST_BASE_FILE_UTILS_H_

OLD	NEW