Omnibox: Create DemoteByType Experiment

base/strings/string_split.h

Index: base/strings/string_split.h
diff --git a/base/strings/string_split.h b/base/strings/string_split.h
index 2803752d03e1ee4164388fabc1575f06bd3232e0..34dae44a7544f0d9b02f5297b53781bdcceab4e0 100644
--- a/base/strings/string_split.h
+++ b/base/strings/string_split.h
@@ -36,11 +36,13 @@ BASE_EXPORT bool SplitStringIntoKeyValues(const std::string& line,
                                           std::string* key,
                                           std::vector<std::string>* values);
 
+typedef std::vector<std::pair<std::string, std::string> > KeyValuePairs;

[darin (slow to review), 2013/08/08 04:40:55]

If I saw base::KeyValuePairs in code, it wouldn't be very obvious that it was
really just a vector of string pairs.  It seems like base::StringPairs would be
a much more descriptive name for this type.  It just so happens that the
SplitStringIntoKeyValuePairs function returns data of that type.  Seems like an
improvement, right?

[Mark P, 2013/08/08 13:16:02]

Yes, that's an improvement.  Done.

+
 BASE_EXPORT bool SplitStringIntoKeyValuePairs(
     const std::string& line,
     char key_value_delimiter,
     char key_value_pair_delimiter,
-    std::vector<std::pair<std::string, std::string> >* kv_pairs);
+    KeyValuePairs* kv_pairs);

[darin (slow to review), 2013/08/08 04:40:55]

nit: while you are here, perhaps kv_pairs can be named key_value_pairs for
consistency with other params?

[Mark P, 2013/08/08 13:16:02]

Okay.  Done.

 
 // The same as SplitString, but use a substring delimiter instead of a char.
 BASE_EXPORT void SplitStringUsingSubstr(const string16& str,