Omnibox: Create DemoteByType Experiment

chrome/browser/omnibox/omnibox_field_trial_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/omnibox/omnibox_field_trial.h"
 
 #include "base/basictypes.h"
+#include "base/memory/scoped_ptr.h"
 #include "base/metrics/field_trial.h"
 #include "base/strings/string16.h"
 #include "chrome/common/metrics/entropy_provider.h"
 #include "chrome/common/metrics/variations/variations_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 class OmniboxFieldTrialTest : public testing::Test {
  public:
-  OmniboxFieldTrialTest() {}
-
-  static void SetUpTestCase() {
+  OmniboxFieldTrialTest() {
     ResetFieldTrialList();
   }
 
-  static void TearDownTestCase() {
-    delete field_trial_list_;
-    field_trial_list_ = NULL;
-  }
-
-  static void ResetFieldTrialList() {
-    // It's important to delete the old pointer first which sets
-    // FieldTrialList::global_ to NULL.
-    if (field_trial_list_)
-      delete field_trial_list_;
-    field_trial_list_ = new base::FieldTrialList(
-        new metrics::SHA1EntropyProvider("foo"));
+  void ResetFieldTrialList() {
+    // Destroy the existing FieldTrialList before creating a new one to avoid
+    // a DCHECK.
+    field_trial_list_.reset();
+    field_trial_list_.reset(new base::FieldTrialList(
+        new metrics::SHA1EntropyProvider("foo")));
+    chrome_variations::testing::ClearAllVariationParams();
     OmniboxFieldTrial::ActivateDynamicTrials();
   }
 
   // Creates and activates a field trial.
   static base::FieldTrial* CreateTestTrial(const std::string& name,
                                            const std::string& group_name) {
     base::FieldTrial* trial = base::FieldTrialList::CreateFieldTrial(
         name, group_name);
     trial->group();
     return trial;
   }
 
+  // EXPECTS that demotions[match_type] exists with value expected_value.
+  static void VerifyDemotion(
+      const OmniboxFieldTrial::DemotionMultipliers& demotions,
+      AutocompleteMatchType::Type match_type,
+      float expected_value);
+
  private:
-  // Needed for Activate{Static/Dynamic}Trials().
-  static base::FieldTrialList* field_trial_list_;
+  scoped_ptr<base::FieldTrialList> field_trial_list_;
 
   DISALLOW_COPY_AND_ASSIGN(OmniboxFieldTrialTest);
 };
 
 // static
-base::FieldTrialList* OmniboxFieldTrialTest::field_trial_list_ = NULL;
+void OmniboxFieldTrialTest::VerifyDemotion(
+    const OmniboxFieldTrial::DemotionMultipliers& demotions,
+    AutocompleteMatchType::Type match_type,
+    float expected_value) {
+  OmniboxFieldTrial::DemotionMultipliers::const_iterator demotion_it =
+      demotions.find(match_type);
+  EXPECT_TRUE(demotion_it != demotions.end());

[Peter Kasting, 2013/08/06 22:19:40]

Nit: ASSERT_TRUE, since you deref this

[Mark P, 2013/08/06 22:44:49]

Done.

+  EXPECT_FLOAT_EQ(expected_value, demotion_it->second);
+}
 
 // Test if GetDisabledProviderTypes() properly parses various field trial
 // group names.
 TEST_F(OmniboxFieldTrialTest, GetDisabledProviderTypes) {
   EXPECT_EQ(0, OmniboxFieldTrial::GetDisabledProviderTypes());
 
   {
     SCOPED_TRACE("Invalid groups");
     CreateTestTrial("AutocompleteDynamicTrial_0", "DisabledProviders_");
     EXPECT_EQ(0, OmniboxFieldTrial::GetDisabledProviderTypes());
@@ skipping 59 matching lines @@
     ResetFieldTrialList();
     CreateTestTrial("AutocompleteDynamicTrial_2", "EnableZeroSuggest_Queries");
     EXPECT_TRUE(OmniboxFieldTrial::InZeroSuggestFieldTrial());
 
     ResetFieldTrialList();
     CreateTestTrial("AutocompleteDynamicTrial_3", "EnableZeroSuggest_URLs");
     EXPECT_TRUE(OmniboxFieldTrial::InZeroSuggestFieldTrial());
   }
 }
 
+TEST_F(OmniboxFieldTrialTest, GetDemotionsByTypeWithFallback) {
+  // Must be the same as kBundledExperimentFieldTrialName
+  // defined in omnibox_field_trial.cc.
+  const std::string kTrialName = "OmniboxBundledExperimentV1";
+  // Must be the same as kDemoteByTypeRule defined in
+  // omnibox_field_trial.cc.
+  const std::string kRuleName = "DemoteByType";
+  {
+    std::map<std::string, std::string> params;
+    params[kRuleName + ":1"] = "1:50,2:0";
+    params[kRuleName + ":3"] = "5:100";
+    params[kRuleName + ":*"] = "1:25";
+    ASSERT_TRUE(chrome_variations::AssociateVariationParams(
+        kTrialName, "A", params));
+  }
+  base::FieldTrialList::CreateFieldTrial(kTrialName, "A");
+  OmniboxFieldTrial::DemotionMultipliers demotions_by_type;
+  OmniboxFieldTrial::GetDemotionsByType(
+      AutocompleteInput::NEW_TAB_PAGE, &demotions_by_type);
+  ASSERT_EQ(2u, demotions_by_type.size());
+  VerifyDemotion(demotions_by_type, AutocompleteMatchType::HISTORY_URL, 0.5);
+  VerifyDemotion(demotions_by_type, AutocompleteMatchType::HISTORY_TITLE, 0.0);
+  OmniboxFieldTrial::GetDemotionsByType(
+      AutocompleteInput::HOMEPAGE, &demotions_by_type);
+  ASSERT_EQ(1u, demotions_by_type.size());
+  VerifyDemotion(demotions_by_type, AutocompleteMatchType::NAVSUGGEST, 1.0);
+  OmniboxFieldTrial::GetDemotionsByType(
+      AutocompleteInput::BLANK, &demotions_by_type);
+  ASSERT_EQ(1u, demotions_by_type.size());
+  VerifyDemotion(demotions_by_type, AutocompleteMatchType::HISTORY_URL, 0.25);
+}
+
 TEST_F(OmniboxFieldTrialTest, GetValueForRuleInContext) {
   // Must be the same as kBundledExperimentFieldTrialName
   // defined in omnibox_field_trial.cc.
   const std::string kTrialName = "OmniboxBundledExperimentV1";
   {
     std::map<std::string, std::string> params;
     // Rule 1 has some exact matches and a global fallback.
     params["rule1:1"] = "rule1-1-value";  // NEW_TAB_PAGE
     params["rule1:3"] = "rule1-3-value";  // HOMEPAGE
     params["rule1:*"] = "rule1-*-value";  // global
@@ skipping 50 matching lines @@
       "rule3-4-value",
       OmniboxFieldTrial::GetValueForRuleInContext(
           "rule3", AutocompleteInput::OTHER));  // exact match
 
   // Tests for rule 4 (a missing rule).
   EXPECT_EQ(
       "",
       OmniboxFieldTrial::GetValueForRuleInContext(
           "rule4", AutocompleteInput::OTHER));  // no rule at all
 }