MD Downloads: show "More Actions" menu in less janky way

MD Downloads: show "More Actions" menu in less janky way

R=michaelpg@chromium.org
BUG=631892
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/8356f186822b16628ee8782af004c2d3fefba7ab
Cr-Commit-Position: refs/heads/master@{#409391}

[Dan Beam, 2016-08-02 17:58:48]

Description was changed from

==========
MD Downloads: show "More Actions" menu in less janky way

R=michaelpg@chromium.org
BUG=631892
==========

to

==========
MD Downloads: show "More Actions" menu in less janky way

R=michaelpg@chromium.org
BUG=631892
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[michaelpg, 2016-08-02 20:48:31]

is this a polymer issue? has russell recommended nowrap?

[Dan Beam, 2016-08-02 21:03:51]

On 2016/08/02 20:48:31, michaelpg wrote:
> is this a polymer issue? has russell recommended nowrap?

I considered explaining this in the CL description / publishing comment, but
didn't for brevity.

I didn't bother sending a Polymer PR because not all UIs:

a) show menus to the right (which exacerbates this issue)
b) want nowrap (only need single-line menu items)
c) have a page-wide min-width to ensure space

downloads does ^.

I also considered dropping animations (no-animations), but felt like they were
improved enough to keep with this added style.

[Dan Beam, 2016-08-02 21:04:11]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 21:04:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[michaelpg, 2016-08-02 21:44:44]

On 2016/08/02 21:03:51, Dan Beam wrote:
> On 2016/08/02 20:48:31, michaelpg wrote:
> > is this a polymer issue? has russell recommended nowrap?
> 
> I considered explaining this in the CL description / publishing comment, but
> didn't for brevity.
> 
> I didn't bother sending a Polymer PR because not all UIs:
> 
> a) show menus to the right (which exacerbates this issue)
> b) want nowrap (only need single-line menu items)
> c) have a page-wide min-width to ensure space
> 
> downloads does ^.
> 
> I also considered dropping animations (no-animations), but felt like they were
> improved enough to keep with this added style.

So maybe it's higher-pri for us, okay.

But it's not really specific to anything you just mentioned:
https://jsfiddle.net/mgiuffrida/r1o0pL74/

I found the bug I filed a while back...
https://github.com/PolymerElements/paper-menu-button/issues/56

where tjsavage suggests the animation is doing the wrong thing altogether.

Do with that info what you will, preferably at minimum a TODO to the issue.

[Dan Beam, 2016-08-02 21:52:20]

On 2016/08/02 21:44:44, michaelpg wrote:
> On 2016/08/02 21:03:51, Dan Beam wrote:
> > On 2016/08/02 20:48:31, michaelpg wrote:
> > > is this a polymer issue? has russell recommended nowrap?
> > 
> > I considered explaining this in the CL description / publishing comment, but
> > didn't for brevity.
> > 
> > I didn't bother sending a Polymer PR because not all UIs:
> > 
> > a) show menus to the right (which exacerbates this issue)
> > b) want nowrap (only need single-line menu items)
> > c) have a page-wide min-width to ensure space
> > 
> > downloads does ^.
> > 
> > I also considered dropping animations (no-animations), but felt like they
were
> > improved enough to keep with this added style.
> 
> So maybe it's higher-pri for us, okay.
> 
> But it's not really specific to anything you just mentioned:
> https://jsfiddle.net/mgiuffrida/r1o0pL74/
> 
> I found the bug I filed a while back...
> https://github.com/PolymerElements/paper-menu-button/issues/56
> 
> where tjsavage suggests the animation is doing the wrong thing altogether.
> 
> Do with that info what you will, preferably at minimum a TODO to the issue.

TODO'd

[Dan Beam, 2016-08-02 21:52:39]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 21:53:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[michaelpg, 2016-08-02 23:00:40]

lgtm....but are you sure you went far enough in expressing yourself?

[commit-bot: I haz the power, 2016-08-02 23:02:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 23:02:49]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2016-08-03 00:06:58]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2016-08-03 00:08:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 00:13:21]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-03 00:16:09]

Description was changed from

==========
MD Downloads: show "More Actions" menu in less janky way

R=michaelpg@chromium.org
BUG=631892
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Downloads: show "More Actions" menu in less janky way

R=michaelpg@chromium.org
BUG=631892
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/8356f186822b16628ee8782af004c2d3fefba7ab
Cr-Commit-Position: refs/heads/master@{#409391}
==========

[commit-bot: I haz the power, 2016-08-03 00:16:10]

Patchset 2 (id:??) landed as
https://crrev.com/8356f186822b16628ee8782af004c2d3fefba7ab
Cr-Commit-Position: refs/heads/master@{#409391}