Issue 2203023002: Make arch-specific constants dependent on sys.info().machine

Issue 2203023002: Make arch-specific constants dependent on sys.info().machine (Closed)

Created:
4 years, 4 months ago by petarj

Modified:
4 years, 4 months ago

Reviewers:
erikcorry, Søren Gjesse

CC:
dartino-code-reviews_googlegroups.com

Base URL:
git@github.com:dartino/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Make arch-specific constants dependent on sys.info().machine Values such as socket constants and types are arch-specific and can only be resolved at runtime. Patch by RT-RK. BUG= https://github.com/dartino/sdk/issues/496 TEST= ninja -C out/DebugXMIPS R=erikcorry@google.com Committed: https://github.com/dartino/sdk/commit/f74712012a96518049650475a0aa573170b5a910

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -10 lines)			Patch
M	pkg/os/lib/src/errno.dart	View	1 2	1 chunk	+3 lines, -2 lines	0 comments	Download
M	pkg/os/lib/src/system_linux.dart	View	1 2	1 chunk	+8 lines, -6 lines	0 comments	Download
M	pkg/os/lib/src/system_posix.dart	View	1 2	1 chunk	+4 lines, -2 lines	0 comments	Download

Total messages: 8 (4 generated)

erikcorry

4 years, 4 months ago (2016-08-10 08:14:53 UTC) #8

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
f74712012a96518049650475a0aa573170b5a910 (presubmit successful).