Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2203013003: Remove unnecessary imports to tree.dart (Closed)

Created:
4 years, 4 months ago by Siggi Cherem (dart-lang)
Modified:
4 years, 4 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : - readd a couple imports #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
M pkg/compiler/lib/src/constant_system_dart.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/constants/constant_system.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/constants/expressions.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/constants/values.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/deferred_load.dart View 4 chunks +4 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_nodes.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_system_javascript.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/constant_ordering.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/string_validator.dart View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
Siggi Cherem (dart-lang)
just importing DartString directly
4 years, 4 months ago (2016-08-02 23:26:47 UTC) #4
Harry Terkelsen
lgtm
4 years, 4 months ago (2016-08-02 23:31:10 UTC) #5
Siggi Cherem (dart-lang)
4 years, 4 months ago (2016-08-03 15:27:56 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:60001) manually as
9aee504527fc21e664738fd5fcdbe347703be406 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698