Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2203003003: Get AcceleratorControllerTest working with mash (Closed)

Created:
4 years, 4 months ago by sky
Modified:
4 years, 4 months ago
Reviewers:
sadrul
CC:
chromium-reviews, kalyank, sadrul, tfarina, oshima+watch_chromium.org, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Get AcceleratorControllerTest working with mash A couple of tests have been commented or disabled because of current lacking functionality in mash. Bugs are filed for all the cases. BUG=612331, 632208, 632209, 630683, 632211, 632180, 632189, 632192, 632200, 632201 TEST=AcceleratorControllerTest* in mash_unittests R=sadrul@chromium.org Committed: https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e Cr-Commit-Position: refs/heads/master@{#409393}

Patch Set 1 #

Patch Set 2 : comment #

Patch Set 3 : merge #

Total comments: 4

Patch Set 4 : feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+329 lines, -184 lines) Patch
M ash/accelerators/accelerator_controller_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/mus/BUILD.gn View 1 2 3 3 chunks +8 lines, -0 lines 0 comments Download
M ash/mus/accelerators/accelerator_controller_registrar.h View 2 chunks +3 lines, -0 lines 0 comments Download
A ash/mus/accelerators/accelerator_controller_registrar_test_api.h View 1 1 chunk +33 lines, -0 lines 0 comments Download
A ash/mus/accelerators/accelerator_controller_registrar_test_api.cc View 1 chunk +43 lines, -0 lines 0 comments Download
M ash/mus/accelerators/accelerator_controller_unittest.cc View 1 2 3 28 chunks +172 lines, -172 lines 0 comments Download
M ash/mus/bridge/wm_root_window_controller_mus.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/mus/bridge/wm_shell_mus.h View 2 chunks +3 lines, -0 lines 0 comments Download
A ash/mus/bridge/wm_shell_mus_test_api.h View 1 chunk +30 lines, -0 lines 0 comments Download
M ash/mus/bridge/wm_window_mus.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M ash/mus/property_util.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/mus/property_util.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M ash/mus/test/wm_test_helper.cc View 3 chunks +11 lines, -1 line 0 comments Download
M ash/test/ash_md_test_base.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ash/test/ash_test_helper.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/mus/native_widget_mus.cc View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
sky
4 years, 4 months ago (2016-08-02 17:25:17 UTC) #3
sadrul
lgtm https://codereview.chromium.org/2203003003/diff/40001/ash/mus/BUILD.gn File ash/mus/BUILD.gn (right): https://codereview.chromium.org/2203003003/diff/40001/ash/mus/BUILD.gn#newcode231 ash/mus/BUILD.gn:231: "//ui/message_center:message_center", Just ui/message_center? https://codereview.chromium.org/2203003003/diff/40001/ash/mus/accelerators/accelerator_controller_unittest.cc File ash/mus/accelerators/accelerator_controller_unittest.cc (right): https://codereview.chromium.org/2203003003/diff/40001/ash/mus/accelerators/accelerator_controller_unittest.cc#newcode661 ...
4 years, 4 months ago (2016-08-02 22:39:51 UTC) #10
sky
https://codereview.chromium.org/2203003003/diff/40001/ash/mus/BUILD.gn File ash/mus/BUILD.gn (right): https://codereview.chromium.org/2203003003/diff/40001/ash/mus/BUILD.gn#newcode231 ash/mus/BUILD.gn:231: "//ui/message_center:message_center", On 2016/08/02 22:39:50, sadrul wrote: > Just ui/message_center? ...
4 years, 4 months ago (2016-08-02 22:50:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2203003003/60001
4 years, 4 months ago (2016-08-02 22:51:33 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/177278)
4 years, 4 months ago (2016-08-02 23:07:42 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2203003003/60001
4 years, 4 months ago (2016-08-03 00:03:06 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-03 00:15:11 UTC) #19
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 00:18:38 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e
Cr-Commit-Position: refs/heads/master@{#409393}

Powered by Google App Engine
This is Rietveld 408576698