[turbofan] Don't generate unnecessary minus zero checks.

src/compiler/simplified-operator.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/simplified-operator.h"
 
 #include "src/base/lazy-instance.h"
 #include "src/compiler/opcodes.h"
 #include "src/compiler/operator.h"
 #include "src/types.h"
@@ skipping 190 matching lines @@
   UNREACHABLE();
   return os;
 }
 
 CheckFloat64HoleMode CheckFloat64HoleModeOf(const Operator* op) {
   DCHECK_EQ(IrOpcode::kCheckFloat64Hole, op->opcode());
   return OpParameter<CheckFloat64HoleMode>(op);
 }
 
 CheckForMinusZeroMode CheckMinusZeroModeOf(const Operator* op) {
-  DCHECK_EQ(IrOpcode::kCheckedInt32Mul, op->opcode());
+  DCHECK(op->opcode() == IrOpcode::kCheckedInt32Mul ||
+         op->opcode() == IrOpcode::kCheckedFloat64ToInt32 ||
+         op->opcode() == IrOpcode::kCheckedTaggedToInt32);
   return OpParameter<CheckForMinusZeroMode>(op);
 }
 
 size_t hash_value(CheckForMinusZeroMode mode) {
   return static_cast<size_t>(mode);
 }
 
 std::ostream& operator<<(std::ostream& os, CheckForMinusZeroMode mode) {
   switch (mode) {
     case CheckForMinusZeroMode::kCheckForMinusZero:
@@ skipping 166 matching lines @@
   V(CheckString, 1, 1)                \
   V(CheckTaggedPointer, 1, 1)         \
   V(CheckTaggedSigned, 1, 1)          \
   V(CheckedInt32Add, 2, 1)            \
   V(CheckedInt32Sub, 2, 1)            \
   V(CheckedInt32Div, 2, 1)            \
   V(CheckedInt32Mod, 2, 1)            \
   V(CheckedUint32Div, 2, 1)           \
   V(CheckedUint32Mod, 2, 1)           \
   V(CheckedUint32ToInt32, 1, 1)       \
-  V(CheckedFloat64ToInt32, 1, 1)      \
   V(CheckedTaggedSignedToInt32, 1, 1) \
-  V(CheckedTaggedToInt32, 1, 1)       \
   V(CheckedTaggedToFloat64, 1, 1)     \
   V(CheckedTruncateTaggedToWord32, 1, 1)
 
 struct SimplifiedOperatorGlobalCache final {
 #define PURE(Name, properties, value_input_count, control_input_count)     \
   struct Name##Operator final : public Operator {                          \
     Name##Operator()                                                       \
         : Operator(IrOpcode::k##Name, Operator::kPure | properties, #Name, \
                    value_input_count, 0, control_input_count, 1, 0, 0) {}  \
   };                                                                       \
@@ skipping 19 matching lines @@
         : Operator1<CheckForMinusZeroMode>(
               IrOpcode::kCheckedInt32Mul,
               Operator::kFoldable | Operator::kNoThrow, "CheckedInt32Mul", 2, 1,
               1, 1, 1, 0, kMode) {}
   };
   CheckedInt32MulOperator<CheckForMinusZeroMode::kCheckForMinusZero>
       kCheckedInt32MulCheckForMinusZeroOperator;
   CheckedInt32MulOperator<CheckForMinusZeroMode::kDontCheckForMinusZero>
       kCheckedInt32MulDontCheckForMinusZeroOperator;
 
+  template <CheckForMinusZeroMode kMode>
+  struct CheckedFloat64ToInt32Operator final
+      : public Operator1<CheckForMinusZeroMode> {
+    CheckedFloat64ToInt32Operator()
+        : Operator1<CheckForMinusZeroMode>(
+              IrOpcode::kCheckedFloat64ToInt32,
+              Operator::kFoldable | Operator::kNoThrow, "CheckedFloat64ToInt32",
+              1, 1, 1, 1, 1, 0, kMode) {}
+  };
+  CheckedFloat64ToInt32Operator<CheckForMinusZeroMode::kCheckForMinusZero>
+      kCheckedFloat64ToInt32CheckForMinusZeroOperator;
+  CheckedFloat64ToInt32Operator<CheckForMinusZeroMode::kDontCheckForMinusZero>
+      kCheckedFloat64ToInt32DontCheckForMinusZeroOperator;
+
+  template <CheckForMinusZeroMode kMode>
+  struct CheckedTaggedToInt32Operator final
+      : public Operator1<CheckForMinusZeroMode> {
+    CheckedTaggedToInt32Operator()
+        : Operator1<CheckForMinusZeroMode>(
+              IrOpcode::kCheckedTaggedToInt32,
+              Operator::kFoldable | Operator::kNoThrow, "CheckedTaggedToInt32",
+              1, 1, 1, 1, 1, 0, kMode) {}
+  };
+  CheckedTaggedToInt32Operator<CheckForMinusZeroMode::kCheckForMinusZero>
+      kCheckedTaggedToInt32CheckForMinusZeroOperator;
+  CheckedTaggedToInt32Operator<CheckForMinusZeroMode::kDontCheckForMinusZero>
+      kCheckedTaggedToInt32DontCheckForMinusZeroOperator;
+
   template <CheckFloat64HoleMode kMode>
   struct CheckFloat64HoleNaNOperator final
       : public Operator1<CheckFloat64HoleMode> {
     CheckFloat64HoleNaNOperator()
         : Operator1<CheckFloat64HoleMode>(
               IrOpcode::kCheckFloat64Hole,
               Operator::kFoldable | Operator::kNoThrow, "CheckFloat64Hole", 1,
               1, 1, 1, 1, 0, kMode) {}
   };
   CheckFloat64HoleNaNOperator<CheckFloat64HoleMode::kAllowReturnHole>
@@ skipping 67 matching lines @@
   switch (mode) {
     case CheckForMinusZeroMode::kCheckForMinusZero:
       return &cache_.kCheckedInt32MulCheckForMinusZeroOperator;
     case CheckForMinusZeroMode::kDontCheckForMinusZero:
       return &cache_.kCheckedInt32MulDontCheckForMinusZeroOperator;
   }
   UNREACHABLE();
   return nullptr;
 }
 
+const Operator* SimplifiedOperatorBuilder::CheckedFloat64ToInt32(
+    CheckForMinusZeroMode mode) {
+  switch (mode) {
+    case CheckForMinusZeroMode::kCheckForMinusZero:
+      return &cache_.kCheckedFloat64ToInt32CheckForMinusZeroOperator;
+    case CheckForMinusZeroMode::kDontCheckForMinusZero:
+      return &cache_.kCheckedFloat64ToInt32DontCheckForMinusZeroOperator;
+  }
+  UNREACHABLE();
+  return nullptr;
+}
+
+const Operator* SimplifiedOperatorBuilder::CheckedTaggedToInt32(
+    CheckForMinusZeroMode mode) {
+  switch (mode) {
+    case CheckForMinusZeroMode::kCheckForMinusZero:
+      return &cache_.kCheckedTaggedToInt32CheckForMinusZeroOperator;
+    case CheckForMinusZeroMode::kDontCheckForMinusZero:
+      return &cache_.kCheckedTaggedToInt32DontCheckForMinusZeroOperator;
+  }
+  UNREACHABLE();
+  return nullptr;
+}
+
 const Operator* SimplifiedOperatorBuilder::CheckMaps(int map_input_count) {
   // TODO(bmeurer): Cache the most important versions of this operator.
   DCHECK_LT(0, map_input_count);
   int const value_input_count = 1 + map_input_count;
   return new (zone()) Operator1<int>(           // --
       IrOpcode::kCheckMaps,                     // opcode
       Operator::kNoThrow | Operator::kNoWrite,  // flags
       "CheckMaps",                              // name
       value_input_count, 1, 1, 0, 1, 0,         // counts
       map_input_count);                         // parameter
@@ skipping 126 matching lines @@
                         Operator::kNoDeopt | Operator::kNoThrow | properties,  \
                         #Name, value_input_count, 1, control_input_count,      \
                         output_count, 1, 0, access);                           \
   }
 ACCESS_OP_LIST(ACCESS)
 #undef ACCESS
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8