Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2202993005: [turbofan] Don't generate unnecessary minus zero checks. (Closed)

Created:
4 years, 4 months ago by Benedikt Meurer
Modified:
4 years, 4 months ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@TurboFan_SignedSmall
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Don't generate unnecessary minus zero checks. When we do a checked conversion from Tagged or Float64 to Int32, we used to always do a minus zero check, even if we already know that the input cannot be minus zero. Now we actually do the check only if we have evidence that the input might be minus zero. R=epertoso@chromium.org BUG=v8:4583 Committed: https://crrev.com/b947fff8afe6dda413033b25010c3d73a7656da5 Cr-Commit-Position: refs/heads/master@{#38308}

Patch Set 1 #

Patch Set 2 : Err, DCHECK, meh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -33 lines) Patch
M src/compiler/effect-control-linearizer.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/effect-control-linearizer.cc View 5 chunks +28 lines, -24 lines 0 comments Download
M src/compiler/representation-change.cc View 3 chunks +12 lines, -3 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 4 chunks +55 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Benedikt Meurer
4 years, 4 months ago (2016-08-03 13:05:33 UTC) #1
epertoso
lgtm Nice.
4 years, 4 months ago (2016-08-03 13:22:39 UTC) #4
epertoso
lgtm Nice.
4 years, 4 months ago (2016-08-03 13:22:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2202993005/20001
4 years, 4 months ago (2016-08-03 16:14:31 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-03 16:34:12 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 16:36:25 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b947fff8afe6dda413033b25010c3d73a7656da5
Cr-Commit-Position: refs/heads/master@{#38308}

Powered by Google App Engine
This is Rietveld 408576698