Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2202993002: [heap] Re-enable black allocation when finalizing marking. (Closed)

Created:
4 years, 4 months ago by Hannes Payer (out of office)
Modified:
4 years, 4 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Re-enable black allocation when finalizing marking. BUG=chromium:630386 LOG=n Committed: https://crrev.com/2c75cfd731e11daa649faf2e91cbb84767b11f8e Cr-Commit-Position: refs/heads/master@{#38240}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
ulan
lgtm
4 years, 4 months ago (2016-08-02 11:32:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2202993002/1
4 years, 4 months ago (2016-08-02 11:53:53 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-02 11:56:28 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2c75cfd731e11daa649faf2e91cbb84767b11f8e Cr-Commit-Position: refs/heads/master@{#38240}
4 years, 4 months ago (2016-08-02 11:59:48 UTC) #13
Hannes Payer (out of office)
4 years, 4 months ago (2016-08-02 12:26:42 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2204593005/ by hpayer@chromium.org.

The reason for reverting is: Crashes on tree..

Powered by Google App Engine
This is Rietveld 408576698