Copy ASan runtime to buildroot on Windows as well as Mac

build/config/sanitizers/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/chrome_build.gni")
 import("//build/config/chromecast_build.gni")
 import("//build/config/clang/clang.gni")
 import("//build/config/sanitizers/sanitizers.gni")
 import("//build/toolchain/toolchain.gni")
 
@@ skipping 48 matching lines @@
     }
 
     if (use_prebuilt_instrumented_libraries ||
         use_locally_built_instrumented_libraries) {
       deps += [ "//third_party/instrumented_libraries:deps" ]
     }
     if (use_custom_libcxx) {
       public_deps += [ "//buildtools/third_party/libc++:libcxx_proxy" ]
       data += [ "$root_out_dir/libc++.so" ]
     }
-    if (is_mac) {
+    if (is_mac || is_win) {
       data_deps = [
         ":copy_asan_runtime",
       ]
 
       public_deps += [ ":asan_runtime_bundle_data" ]
     }
   }
 }
 
-if (is_mac && using_sanitizer) {
+if ((is_mac || is_win) && using_sanitizer) {

[Dirk Pranke, 2016/08/03 00:06:10]

This isn't quite right, because now bundle_data("asan_runtime_bundle_data") will
be defined as a target as well. That one should be mac-only.

However, I think bundle_data() is a no-op on windows so it might be relatively
harmless.

   copy("copy_asan_runtime") {
+    if (is_mac) {
+      clang_rt_dso_path = "darwin/libclang_rt.asan_osx_dynamic.dylib"
+    } else if (is_win && target_cpu == "x86") {
+      clang_rt_dso_path = "windows/clang_rt.asan_dynamic-i386.dll"
+    } else if (is_win && target_cpu == "x64") {
+      clang_rt_dso_path = "windows/clang_rt.asan_dynamic-x86_64.dll"

[Nico, 2016/08/02 22:00:49]

Is this enough? atm asan is enabled for not just target binaries I think, so
from what I can tell in 32-bit builds we still build some nacl binaries in
64-bit with asan. We probably shouldn't do that, but at the moment I think we
do.

[Reid Kleckner, 2016/08/02 22:13:16]

I only know it's enough to make base_unittests and sbox_integration_tests start
working. :) Like you say, I think we can tackle the nacl thing separately.

+    }
     sources = [
-      "$clang_base_path/lib/clang/$clang_version/lib/darwin/libclang_rt.asan_osx_dynamic.dylib",
+      "$clang_base_path/lib/clang/$clang_version/lib/$clang_rt_dso_path",
     ]
     outputs = [
       "$root_out_dir/{{source_file_part}}",
     ]
   }
 
   bundle_data("asan_runtime_bundle_data") {
     sources = get_target_outputs(":copy_asan_runtime")
     outputs = [
       "{{bundle_executable_dir}}/{{source_file_part}}",
@@ skipping 364 matching lines @@
 # This allows to selectively disable ubsan_vptr, when needed. In particular,
 # if some third_party code is required to be compiled without rtti, which
 # is a requirement for ubsan_vptr.
 config("default_sanitizer_flags_but_ubsan_vptr") {
   configs = all_sanitizer_configs - [ ":ubsan_vptr_flags" ]
 }
 
 config("default_sanitizer_flags_but_coverage") {
   configs = all_sanitizer_configs - [ ":coverage_flags" ]
 }