Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Unified Diff: runtime/observatory/lib/src/app/page.dart

Issue 2202973002: Converted Observatory isolate-reconnect element (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Fixed typo Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/app/page.dart
diff --git a/runtime/observatory/lib/src/app/page.dart b/runtime/observatory/lib/src/app/page.dart
index 9d624c1c2c52fd9508ac8c995b4694f2f54b232e..460be214761c38d6ba4de6237282058d19655fe7 100644
--- a/runtime/observatory/lib/src/app/page.dart
+++ b/runtime/observatory/lib/src/app/page.dart
@@ -389,15 +389,19 @@ class VMConnectPage extends Page {
class IsolateReconnectPage extends Page {
IsolateReconnectPage(app) : super(app);
+ DivElement container = new DivElement();
+
void onInstall() {
- if (element == null) {
- element = new Element.tag('isolate-reconnect');
- }
- assert(element != null);
+ element = container;
}
void _visit(Uri uri) {
app.vm.reload();
+ container.children = [
+ new IsolateReconnectElement(app.vm, app.events, app.notifications,
+ uri.queryParameters['isolateId'],
+ Uri.parse(uri.queryParameters['originalUri']))
+ ];
assert(element != null);
assert(canVisit(uri));
}
« no previous file with comments | « runtime/observatory/lib/src/app/location_manager.dart ('k') | runtime/observatory/lib/src/elements/css/shared.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698