Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: runtime/observatory/lib/src/app/page.dart

Issue 2202973002: Converted Observatory isolate-reconnect element (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/app/page.dart
diff --git a/runtime/observatory/lib/src/app/page.dart b/runtime/observatory/lib/src/app/page.dart
index 0129c3483241971b0cf60005fb511c885deb1f34..50b35610ec9abd69ab52023f9b3bdcffe986baf7 100644
--- a/runtime/observatory/lib/src/app/page.dart
+++ b/runtime/observatory/lib/src/app/page.dart
@@ -392,14 +392,16 @@ class IsolateReconnectPage extends Page {
IsolateReconnectPage(app) : super(app);
void onInstall() {
- if (element == null) {
- element = new Element.tag('isolate-reconnect');
- }
- assert(element != null);
+ element = new IsolateReconnectElement(app.vm, app.vm.changes.map((_) {
+ new VMUpdateEventMock(vm: app.vm);
+ }), app.notifications);
}
void _visit(Uri uri) {
app.vm.reload();
+ (element as IsolateReconnectElement)
+ ..missing = uri.queryParameters['isolateId']
+ ..uri = Uri.parse(uri.queryParameters['originalUri']);
assert(element != null);
assert(canVisit(uri));
}

Powered by Google App Engine
This is Rietveld 408576698