Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2202973002: Converted Observatory isolate-reconnect element (Closed)

Created:
4 years, 4 months ago by cbernaschina
Modified:
4 years, 4 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Removed commented out code #

Patch Set 3 : Added tests #

Total comments: 2

Patch Set 4 : Fixed typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -54 lines) Patch
M runtime/observatory/lib/elements.dart View 1 2 3 chunks +3 lines, -0 lines 0 comments Download
M runtime/observatory/lib/elements.html View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/app/location_manager.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/app/page.dart View 1 2 1 chunk +8 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/elements/css/shared.css View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/isolate_reconnect.dart View 1 2 3 1 chunk +101 lines, -14 lines 0 comments Download
D runtime/observatory/lib/src/elements/isolate_reconnect.html View 1 chunk +0 lines, -33 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
A runtime/observatory/tests/observatory_ui/isolate_reconnect/element_test.dart View 1 2 1 chunk +79 lines, -0 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/isolate_reconnect/element_test.html View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
cbernaschina
4 years, 4 months ago (2016-08-02 03:55:50 UTC) #2
Cutch
LGTM but wait for Ryan's review https://codereview.chromium.org/2202973002/diff/1/runtime/observatory/lib/src/elements/isolate_reconnect.dart File runtime/observatory/lib/src/elements/isolate_reconnect.dart (right): https://codereview.chromium.org/2202973002/diff/1/runtime/observatory/lib/src/elements/isolate_reconnect.dart#newcode113 runtime/observatory/lib/src/elements/isolate_reconnect.dart:113: /*get missingIsolateId { ...
4 years, 4 months ago (2016-08-02 13:51:11 UTC) #3
cbernaschina
https://codereview.chromium.org/2202973002/diff/1/runtime/observatory/lib/src/elements/isolate_reconnect.dart File runtime/observatory/lib/src/elements/isolate_reconnect.dart (right): https://codereview.chromium.org/2202973002/diff/1/runtime/observatory/lib/src/elements/isolate_reconnect.dart#newcode113 runtime/observatory/lib/src/elements/isolate_reconnect.dart:113: /*get missingIsolateId { On 2016/08/02 13:51:11, Cutch wrote: > ...
4 years, 4 months ago (2016-08-02 15:53:07 UTC) #4
cbernaschina
4 years, 4 months ago (2016-08-05 20:22:57 UTC) #5
cbernaschina
4 years, 4 months ago (2016-08-05 20:23:07 UTC) #6
rmacnak
LGTM https://chromiumcodereview.appspot.com/2202973002/diff/40001/runtime/observatory/lib/src/elements/isolate_reconnect.dart File runtime/observatory/lib/src/elements/isolate_reconnect.dart (right): https://chromiumcodereview.appspot.com/2202973002/diff/40001/runtime/observatory/lib/src/elements/isolate_reconnect.dart#newcode5 runtime/observatory/lib/src/elements/isolate_reconnect.dart:5: library isolate_riconnect_element; reconnect
4 years, 4 months ago (2016-08-08 19:14:29 UTC) #7
cbernaschina
https://codereview.chromium.org/2202973002/diff/40001/runtime/observatory/lib/src/elements/isolate_reconnect.dart File runtime/observatory/lib/src/elements/isolate_reconnect.dart (right): https://codereview.chromium.org/2202973002/diff/40001/runtime/observatory/lib/src/elements/isolate_reconnect.dart#newcode5 runtime/observatory/lib/src/elements/isolate_reconnect.dart:5: library isolate_riconnect_element; On 2016/08/08 19:14:29, rmacnak wrote: > reconnect ...
4 years, 4 months ago (2016-08-08 20:06:43 UTC) #8
cbernaschina
4 years, 4 months ago (2016-08-08 20:07:17 UTC) #10
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
4329f962b2c891cfd7d41e88592e539feab032a8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698