Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2202943002: Converted Observatory error-ref element (Closed)

Created:
4 years, 4 months ago by cbernaschina
Modified:
4 years, 4 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -47 lines) Patch
M runtime/observatory/lib/elements.dart View 3 chunks +8 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/elements/css/shared.css View 3 chunks +16 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/error_ref.dart View 1 chunk +44 lines, -5 lines 0 comments Download
D runtime/observatory/lib/src/elements/error_ref.html View 1 chunk +0 lines, -25 lines 0 comments Download
A runtime/observatory/lib/src/elements/error_ref_wrapper.dart View 1 chunk +78 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/eval_box.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/eval_link.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 chunk +1 line, -1 line 0 comments Download
A + runtime/observatory/tests/observatory_ui/error_ref/element_test.dart View 1 chunk +12 lines, -10 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/error_ref/element_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
cbernaschina
4 years, 4 months ago (2016-08-02 03:02:20 UTC) #2
Cutch
lgtm
4 years, 4 months ago (2016-08-02 13:54:12 UTC) #3
cbernaschina
4 years, 4 months ago (2016-08-02 20:51:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bd797321013b1313eff551ff4683cfd936bef1f2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698