Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2202933002: Remove some further grammar checking code from SpellChecker (Closed)

Created:
4 years, 4 months ago by Xiaocheng
Modified:
4 years, 4 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews, groby+blinkspell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove some further grammar checking code from SpellChecker This patch removes code for grammar checking and grammar marker manipulation from the following member functions of SpellChecker: advanceToNextMisspelling() markAndReplaceFor() didEndEditingOnTextField() respondToChangedSelection() requestTextChecking() BUG=619452 TESt=n/a; no visible change Committed: https://crrev.com/579c127d36de5035a5084b9aa88697f18b0a4552 Cr-Commit-Position: refs/heads/master@{#409150}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -92 lines) Patch
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp View 6 chunks +6 lines, -92 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Xiaocheng
PTAL.
4 years, 4 months ago (2016-08-02 04:09:00 UTC) #5
yosin_UTC9
lgtm
4 years, 4 months ago (2016-08-02 07:07:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2202933002/1
4 years, 4 months ago (2016-08-02 07:07:42 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-02 07:11:11 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 07:12:33 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/579c127d36de5035a5084b9aa88697f18b0a4552
Cr-Commit-Position: refs/heads/master@{#409150}

Powered by Google App Engine
This is Rietveld 408576698