[turbofan] Unify number operation typing rules.

test/cctest/compiler/test-simplified-lowering.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <limits>
 
 #include "src/ast/scopes.h"
 #include "src/compiler/access-builder.h"
 #include "src/compiler/control-builders.h"
 #include "src/compiler/effect-control-linearizer.h"
@@ skipping 1529 matching lines @@
                            load0, load1, t.start);
     t.Return(t.Use(phi, kMachineTypes[i]));
     t.Lower();
 
     CHECK_EQ(IrOpcode::kPhi, phi->opcode());
     CHECK_EQ(kMachineTypes[i].representation(), PhiRepresentationOf(phi->op()));
   }
 }
 
 
-TEST(RunNumberDivide_minus_1_TruncatingToInt32) {
-  SimplifiedLoweringTester<Object*> t(MachineType::AnyTagged());
-  Node* num = t.NumberToInt32(t.Parameter(0));
-  Node* div = t.NumberDivide(num, t.jsgraph.Constant(-1));
-  Node* trunc = t.NumberToInt32(div);
-  t.Return(trunc);
-
-  t.LowerAllNodesAndLowerChanges();
-  t.GenerateCode();
-
-  FOR_INT32_INPUTS(i) {
-    int32_t x = 0 - *i;
-    t.CheckNumberCall(static_cast<double>(x), static_cast<double>(*i));
-  }
-}
-
-
-TEST(RunNumberMultiply_TruncatingToInt32) {
-  int32_t constants[] = {-100, -10, -1, 0, 1, 100, 1000, 3000999};
-
-  for (size_t i = 0; i < arraysize(constants); i++) {
-    double k = static_cast<double>(constants[i]);
-    SimplifiedLoweringTester<Object*> t(MachineType::AnyTagged());
-    Node* num = t.NumberToInt32(t.Parameter(0));
-    Node* mul = t.NumberMultiply(num, t.jsgraph.Constant(k));
-    Node* trunc = t.NumberToInt32(mul);
-    t.Return(trunc);
-
-      t.LowerAllNodesAndLowerChanges();
-      t.GenerateCode();
-
-      FOR_INT32_INPUTS(i) {
-        int32_t x = DoubleToInt32(static_cast<double>(*i) * k);
-        t.CheckNumberCall(static_cast<double>(x), static_cast<double>(*i));
-      }
-    }
-}
-
-
-TEST(RunNumberMultiply_TruncatingToUint32) {
-  uint32_t constants[] = {0, 1, 2, 3, 4, 100, 1000, 1024, 2048, 3000999};
-
-  for (size_t i = 0; i < arraysize(constants); i++) {
-    double k = static_cast<double>(constants[i]);
-    SimplifiedLoweringTester<Object*> t(MachineType::AnyTagged());
-    Node* num = t.NumberToUint32(t.Parameter(0));
-    Node* mul = t.NumberMultiply(num, t.jsgraph.Constant(k));
-    Node* trunc = t.NumberToUint32(mul);
-    t.Return(trunc);
-
-      t.LowerAllNodesAndLowerChanges();
-      t.GenerateCode();
-
-      FOR_UINT32_INPUTS(i) {
-        uint32_t x = DoubleToUint32(static_cast<double>(*i) * k);
-        t.CheckNumberCall(static_cast<double>(x), static_cast<double>(*i));
-    }
-  }
-}
-
-
-TEST(RunNumberDivide_2_TruncatingToUint32) {
-  SimplifiedLoweringTester<Object*> t(MachineType::AnyTagged());
-  Node* num = t.NumberToUint32(t.Parameter(0));
-  Node* div = t.NumberDivide(num, t.jsgraph.Constant(2));
-  Node* trunc = t.NumberToUint32(div);
-  t.Return(trunc);
-
-    t.LowerAllNodesAndLowerChanges();
-    t.GenerateCode();
-
-    FOR_UINT32_INPUTS(i) {
-      uint32_t x = DoubleToUint32(static_cast<double>(*i / 2.0));
-      t.CheckNumberCall(static_cast<double>(x), static_cast<double>(*i));
-    }
-}
-
-
 TEST(NumberMultiply_ConstantOutOfRange) {
   TestingGraph t(Type::Signed32());
   Node* k = t.jsgraph.Constant(1000000023);
   Node* mul = t.graph()->NewNode(t.simplified()->NumberMultiply(), t.p0, k);
   Node* trunc = t.graph()->NewNode(t.simplified()->NumberToInt32(), mul);
   t.Return(trunc);
   t.Lower();
 
   CHECK_EQ(IrOpcode::kFloat64Mul, mul->opcode());
 }
@@ skipping 19 matching lines @@
     Node* div = t.graph()->NewNode(t.simplified()->NumberDivide(), t.p0, k);
     Node* use = t.Use(div, MachineType::Int32());
     t.Return(use);
     t.Lower();
 
     CHECK_EQ(IrOpcode::kInt32Div, use->InputAt(0)->opcode());
   }
 }
 
 
-TEST(RunNumberDivide_TruncatingToInt32) {
-  int32_t constants[] = {-100, -10, -1, 1, 2, 100, 1000, 1024, 2048};
-
-  for (size_t i = 0; i < arraysize(constants); i++) {
-    int32_t k = constants[i];
-    SimplifiedLoweringTester<Object*> t(MachineType::AnyTagged());
-    Node* num = t.NumberToInt32(t.Parameter(0));
-    Node* div = t.NumberDivide(num, t.jsgraph.Constant(k));
-    Node* trunc = t.NumberToInt32(div);
-    t.Return(trunc);
-
-      t.LowerAllNodesAndLowerChanges();
-      t.GenerateCode();
-
-      FOR_INT32_INPUTS(i) {
-        if (*i == INT_MAX) continue;  // exclude max int.
-        int32_t x = DoubleToInt32(static_cast<double>(*i) / k);
-        t.CheckNumberCall(static_cast<double>(x), static_cast<double>(*i));
-    }
-  }
-}
-
-
 TEST(NumberDivide_TruncatingToUint32) {
   double constants[] = {1, 3, 100, 1000, 100998348};
 
   for (size_t i = 0; i < arraysize(constants); i++) {
     TestingGraph t(Type::Unsigned32());
     Node* k = t.jsgraph.Constant(constants[i]);
     Node* div = t.graph()->NewNode(t.simplified()->NumberDivide(), t.p0, k);
     Node* use = t.Use(div, MachineType::Uint32());
     t.Return(use);
     t.Lower();
 
     CHECK_EQ(IrOpcode::kUint32Div, use->InputAt(0)->opcode());
   }
 }
 
 
-TEST(RunNumberDivide_TruncatingToUint32) {
-  uint32_t constants[] = {100, 10, 1, 1, 2, 4, 1000, 1024, 2048};
-
-  for (size_t i = 0; i < arraysize(constants); i++) {
-    uint32_t k = constants[i];
-    SimplifiedLoweringTester<Object*> t(MachineType::AnyTagged());
-    Node* num = t.NumberToUint32(t.Parameter(0));
-    Node* div = t.NumberDivide(num, t.jsgraph.Constant(static_cast<double>(k)));
-    Node* trunc = t.NumberToUint32(div);
-    t.Return(trunc);
-
-      t.LowerAllNodesAndLowerChanges();
-      t.GenerateCode();
-
-      FOR_UINT32_INPUTS(i) {
-        uint32_t x = *i / k;
-        t.CheckNumberCall(static_cast<double>(x), static_cast<double>(*i));
-    }
-  }
-}
-
-
 TEST(NumberDivide_BadConstants) {
   {
     TestingGraph t(Type::Signed32());
     Node* k = t.jsgraph.Constant(-1);
     Node* div = t.graph()->NewNode(t.simplified()->NumberDivide(), t.p0, k);
     Node* use = t.Use(div, MachineType::Int32());
     t.Return(use);
     t.Lower();
 
     CHECK_EQ(IrOpcode::kInt32Sub, use->InputAt(0)->opcode());
@@ skipping 34 matching lines @@
     Node* mod = t.graph()->NewNode(t.simplified()->NumberModulus(), t.p0, k);
     Node* use = t.Use(mod, MachineType::Int32());
     t.Return(use);
     t.Lower();
 
     CHECK_EQ(IrOpcode::kInt32Mod, use->InputAt(0)->opcode());
   }
 }
 
 
-TEST(RunNumberModulus_TruncatingToInt32) {
-  int32_t constants[] = {-100, -10, -1, 1, 2, 100, 1000, 1024, 2048};
-
-  for (size_t i = 0; i < arraysize(constants); i++) {
-    int32_t k = constants[i];
-    SimplifiedLoweringTester<Object*> t(MachineType::AnyTagged());
-    Node* num = t.NumberToInt32(t.Parameter(0));
-    Node* mod = t.NumberModulus(num, t.jsgraph.Constant(k));
-    Node* trunc = t.NumberToInt32(mod);
-    t.Return(trunc);
-
-      t.LowerAllNodesAndLowerChanges();
-      t.GenerateCode();
-
-      FOR_INT32_INPUTS(i) {
-        if (*i == INT_MAX) continue;  // exclude max int.
-        int32_t x = DoubleToInt32(std::fmod(static_cast<double>(*i), k));
-        t.CheckNumberCall(static_cast<double>(x), static_cast<double>(*i));
-    }
-  }
-}
-
-
 TEST(NumberModulus_TruncatingToUint32) {
   double constants[] = {1, 3, 100, 1000, 100998348};
 
   for (size_t i = 0; i < arraysize(constants); i++) {
     TestingGraph t(Type::Unsigned32());
     Node* k = t.jsgraph.Constant(constants[i]);
     Node* mod = t.graph()->NewNode(t.simplified()->NumberModulus(), t.p0, k);
     Node* trunc = t.graph()->NewNode(t.simplified()->NumberToUint32(), mod);
     t.Return(trunc);
     t.Lower();
 
     CHECK_EQ(IrOpcode::kUint32Mod, t.ret->InputAt(0)->InputAt(0)->opcode());
   }
 }
 
 
-TEST(RunNumberModulus_TruncatingToUint32) {
-  uint32_t constants[] = {1, 2, 100, 1000, 1024, 2048};
-
-  for (size_t i = 0; i < arraysize(constants); i++) {
-    uint32_t k = constants[i];
-    SimplifiedLoweringTester<Object*> t(MachineType::AnyTagged());
-    Node* num = t.NumberToUint32(t.Parameter(0));
-    Node* mod =
-        t.NumberModulus(num, t.jsgraph.Constant(static_cast<double>(k)));
-    Node* trunc = t.NumberToUint32(mod);
-    t.Return(trunc);
-
-      t.LowerAllNodesAndLowerChanges();
-      t.GenerateCode();
-
-      FOR_UINT32_INPUTS(i) {
-        uint32_t x = *i % k;
-        t.CheckNumberCall(static_cast<double>(x), static_cast<double>(*i));
-    }
-  }
-}
-
-
 TEST(NumberModulus_Int32) {
   int32_t constants[] = {-100, -10, 1, 4, 100, 1000};
 
   for (size_t i = 0; i < arraysize(constants); i++) {
     TestingGraph t(Type::Signed32());
     Node* k = t.jsgraph.Constant(constants[i]);
     Node* mod = t.graph()->NewNode(t.simplified()->NumberModulus(), t.p0, k);
     t.Return(mod);
     t.Lower();
 
@@ skipping 62 matching lines @@
     t.Return(use);
     t.Lower();
 
     CHECK_EQ(d.expected, PhiRepresentationOf(phi->op()));
   }
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8