Icon Capture For Window Capturer

Icon Capture

For better usability, we wants to display icon for window capture.

In this CL, we used OS API to extract icon image in WindowCapturer.

In the future CL, we will use display the icon onto the UI.

BUG=631604

[qiangchen, 2016-08-02 21:49:25]

Patchset #3 (id:40001) has been deleted

[qiangchen, 2016-08-02 21:49:33]

Patchset #1 (id:1) has been deleted

[qiangchen, 2016-08-02 21:49:36]

Patchset #1 (id:20001) has been deleted

[qiangchen, 2016-08-02 22:08:48]

Patchset #2 (id:80001) has been deleted

[qiangchen, 2016-08-02 22:08:52]

Patchset #1 (id:60001) has been deleted

[qiangchen, 2016-08-02 22:43:12]

Patchset #1 (id:100001) has been deleted

[qiangchen, 2016-08-04 23:42:26]

Description was changed from

==========
Icon Capture

BUG=
==========

to

==========
Icon Capture

For window capturer, we add the icon image information to the window
list. The motivation is to make the usability better.

BUG=631604
==========

[qiangchen, 2016-08-05 15:46:17]

Patchset #1 (id:120001) has been deleted

[qiangchen, 2016-08-05 15:46:25]

Patchset #1 (id:140001) has been deleted

[qiangchen, 2016-08-05 15:54:42]

qiangchen@chromium.org changed reviewers:
+ sergeyu@chromium.org

[qiangchen, 2016-08-05 15:59:28]

Can you take a look?

We want to get icon image for window capture.

[qiangchen, 2016-08-08 16:27:08]

Description was changed from

==========
Icon Capture

For window capturer, we add the icon image information to the window
list. The motivation is to make the usability better.

BUG=631604
==========

to

==========
Icon Capture

For window capturer, we add the icon image information to the window
list, so that we can display icon on the picker window. The motivation 
is to make the usability better.

BUG=631604
==========

[qiangchen, 2016-08-08 16:46:09]

Description was changed from

==========
Icon Capture

For window capturer, we add the icon image information to the window
list, so that we can display icon on the picker window. The motivation 
is to make the usability better.

BUG=631604
==========

to

==========
Icon Capture

For better usability, we wants to display icon for window capture.

In this CL, we used OS API to extract icon image in WindowCapturer.

In the future CL, we will use display the icon onto the UI.

BUG=631604
==========

[qiangchen, 2016-08-09 22:23:16]

Patchset #2 (id:180001) has been deleted

[qiangchen, 2016-08-11 20:34:11]

Patchset #5 (id:260001) has been deleted

[qiangchen, 2016-08-11 20:55:14]

Patchset #5 (id:280001) has been deleted

[Sergey Ulanov, 2016-08-12 06:00:29]

Does this functionality need to be part of WindowCapturer?
I'm not sure it even needs to be in webrtc. Why not put it somewhere in
chromium, where the picker UI is implemented?

https://codereview.chromium.org/2202883003/diff/320001/webrtc/modules/desktop...
File webrtc/modules/desktop_capture/mac/window_list_utils.mm (right):

https://codereview.chromium.org/2202883003/diff/320001/webrtc/modules/desktop...
webrtc/modules/desktop_capture/mac/window_list_utils.mm:64: for (int y = 0; y <
height; ++y) {
Use ABGRToARGB() from libyuv to convert ABGR to ARGB.

[qiangchen, 2016-08-12 22:09:00]

On 2016/08/12 06:00:29, Sergey Ulanov wrote:
> Does this functionality need to be part of WindowCapturer?
> I'm not sure it even needs to be in webrtc. Why not put it somewhere in
> chromium, where the picker UI is implemented?
> 
>
https://codereview.chromium.org/2202883003/diff/320001/webrtc/modules/desktop...
> File webrtc/modules/desktop_capture/mac/window_list_utils.mm (right):
> 
>
https://codereview.chromium.org/2202883003/diff/320001/webrtc/modules/desktop...
> webrtc/modules/desktop_capture/mac/window_list_utils.mm:64: for (int y = 0; y
<
> height; ++y) {
> Use ABGRToARGB() from libyuv to convert ABGR to ARGB.

The UI is at 
src/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.h

My thinking was to use the same code path as we stream window title to stream
window icon.
It is from webrtc::WindowCapturer ---> DestkopMediaList ---> UI

I think your suggestions is to write some utility function somewhere in
Chromium, and let UI part call those functions to get icon from id?

[Sergey Ulanov, 2016-08-12 23:40:12]

On 2016/08/12 22:09:00, qiangchenC wrote:
> On 2016/08/12 06:00:29, Sergey Ulanov wrote:
> > Does this functionality need to be part of WindowCapturer?
> > I'm not sure it even needs to be in webrtc. Why not put it somewhere in
> > chromium, where the picker UI is implemented?
> > 
> >
>
https://codereview.chromium.org/2202883003/diff/320001/webrtc/modules/desktop...
> > File webrtc/modules/desktop_capture/mac/window_list_utils.mm (right):
> > 
> >
>
https://codereview.chromium.org/2202883003/diff/320001/webrtc/modules/desktop...
> > webrtc/modules/desktop_capture/mac/window_list_utils.mm:64: for (int y = 0;
y
> <
> > height; ++y) {
> > Use ABGRToARGB() from libyuv to convert ABGR to ARGB.
> 
> The UI is at 
> src/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.h
> 
> My thinking was to use the same code path as we stream window title to stream
> window icon.
> It is from webrtc::WindowCapturer ---> DestkopMediaList ---> UI
> 
> I think your suggestions is to write some utility function somewhere in
> Chromium, and let UI part call those functions to get icon from id?

Correct, I suggest to put this code in chrome/browser/ui/views/desktop_capture.
An alternative is to put this function somewhere in
webrtc/modules/desktop_capture, but I don't really see a good reason to put it
here.