Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2202883003: Icon Capture For Window Capturer (Closed)

Created:
4 years, 4 months ago by qiangchen
Modified:
4 years, 4 months ago
Reviewers:
Sergey Ulanov
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Icon Capture For better usability, we wants to display icon for window capture. In this CL, we used OS API to extract icon image in WindowCapturer. In the future CL, we will use display the icon onto the UI. BUG=631604

Patch Set 1 #

Patch Set 2 : Typo fix #

Patch Set 3 : Linux PreMultiply #

Patch Set 4 : Fix Linux Crash #

Patch Set 5 : Fix Windows And Mac #

Patch Set 6 : Fix windows crash #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+235 lines, -186 lines) Patch
M webrtc/modules/desktop_capture/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/desktop_capture/desktop_capture.gypi View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/desktop_capture/mac/window_list_utils.cc View 1 chunk +0 lines, -114 lines 0 comments Download
A + webrtc/modules/desktop_capture/mac/window_list_utils.mm View 1 2 3 4 7 chunks +71 lines, -14 lines 1 comment Download
M webrtc/modules/desktop_capture/window_capturer.h View 2 chunks +4 lines, -0 lines 0 comments Download
M webrtc/modules/desktop_capture/window_capturer_mac.mm View 1 chunk +1 line, -46 lines 0 comments Download
M webrtc/modules/desktop_capture/window_capturer_win.cc View 1 2 3 4 5 3 chunks +78 lines, -4 lines 0 comments Download
M webrtc/modules/desktop_capture/window_capturer_x11.cc View 1 2 3 8 chunks +79 lines, -6 lines 0 comments Download

Messages

Total messages: 19 (15 generated)
qiangchen
Can you take a look? We want to get icon image for window capture.
4 years, 4 months ago (2016-08-05 15:59:28 UTC) #11
Sergey Ulanov
Does this functionality need to be part of WindowCapturer? I'm not sure it even needs ...
4 years, 4 months ago (2016-08-12 06:00:29 UTC) #17
qiangchen
On 2016/08/12 06:00:29, Sergey Ulanov wrote: > Does this functionality need to be part of ...
4 years, 4 months ago (2016-08-12 22:09:00 UTC) #18
Sergey Ulanov
4 years, 4 months ago (2016-08-12 23:40:12 UTC) #19
On 2016/08/12 22:09:00, qiangchenC wrote:
> On 2016/08/12 06:00:29, Sergey Ulanov wrote:
> > Does this functionality need to be part of WindowCapturer?
> > I'm not sure it even needs to be in webrtc. Why not put it somewhere in
> > chromium, where the picker UI is implemented?
> > 
> >
>
https://codereview.chromium.org/2202883003/diff/320001/webrtc/modules/desktop...
> > File webrtc/modules/desktop_capture/mac/window_list_utils.mm (right):
> > 
> >
>
https://codereview.chromium.org/2202883003/diff/320001/webrtc/modules/desktop...
> > webrtc/modules/desktop_capture/mac/window_list_utils.mm:64: for (int y = 0;
y
> <
> > height; ++y) {
> > Use ABGRToARGB() from libyuv to convert ABGR to ARGB.
> 
> The UI is at 
> src/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.h
> 
> My thinking was to use the same code path as we stream window title to stream
> window icon.
> It is from webrtc::WindowCapturer ---> DestkopMediaList ---> UI
> 
> I think your suggestions is to write some utility function somewhere in
> Chromium, and let UI part call those functions to get icon from id?

Correct, I suggest to put this code in chrome/browser/ui/views/desktop_capture.
An alternative is to put this function somewhere in
webrtc/modules/desktop_capture, but I don't really see a good reason to put it
here.

Powered by Google App Engine
This is Rietveld 408576698