Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Unified Diff: build/toolchain/cros/BUILD.gn

Issue 2202873002: Rework approach to allowing extra flags for CrOS builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add_cros_nacl_bootstrap_args
Patch Set: fix typos, type checking Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/cros/BUILD.gn ('k') | build/toolchain/gcc_toolchain.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/toolchain/cros/BUILD.gn
diff --git a/build/toolchain/cros/BUILD.gn b/build/toolchain/cros/BUILD.gn
index bf139dc12da8192f02bd1e7c83e18c3a77f795a5..999a22b0509cbdd30f974c4c68a0b1b0b2cdf7e6 100644
--- a/build/toolchain/cros/BUILD.gn
+++ b/build/toolchain/cros/BUILD.gn
@@ -22,10 +22,6 @@ gcc_toolchain("target") {
if (cros_target_readelf != "") {
readelf = cros_target_readelf
}
- extra_cflags = cros_target_extra_cflags
- extra_cppflags = cros_target_extra_cppflags
- extra_cxxflags = cros_target_extra_cxxflags
- extra_ldflags = cros_target_extra_ldflags
toolchain_args = {
cc_wrapper = ""
@@ -56,10 +52,6 @@ gcc_toolchain("nacl_bootstrap") {
if (cros_target_readelf != "") {
readelf = cros_target_readelf
}
- extra_cflags = cros_nacl_bootstrap_extra_cflags
- extra_cppflags = cros_nacl_bootstrap_extra_cppflags
- extra_cxxflags = cros_nacl_bootstrap_extra_cxxflags
- extra_ldflags = cros_nacl_bootstrap_extra_ldflags
toolchain_args = {
cc_wrapper = ""
@@ -87,10 +79,6 @@ gcc_toolchain("host") {
if (cros_host_readelf != "") {
readelf = cros_host_readelf
}
- extra_cflags = cros_host_extra_cflags
- extra_cppflags = cros_host_extra_cppflags
- extra_cxxflags = cros_host_extra_cxxflags
- extra_ldflags = cros_host_extra_ldflags
toolchain_args = {
cc_wrapper = ""
@@ -116,10 +104,6 @@ gcc_toolchain("v8_snapshot") {
if (cros_v8_snapshot_readelf != "") {
readelf = cros_v8_snapshot_readelf
}
- extra_cflags = cros_v8_snapshot_extra_cflags
- extra_cppflags = cros_v8_snapshot_extra_cppflags
- extra_cxxflags = cros_v8_snapshot_extra_cxxflags
- extra_ldflags = cros_v8_snapshot_extra_ldflags
toolchain_args = {
cc_wrapper = ""
« no previous file with comments | « build/config/cros/BUILD.gn ('k') | build/toolchain/gcc_toolchain.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698