Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 2202873002: Rework approach to allowing extra flags for CrOS builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add_cros_nacl_bootstrap_args
Patch Set: fix typos, type checking Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/config/BUILDCONFIG.gn ('k') | build/config/cros/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/nacl/config.gni") 8 import("//build/config/nacl/config.gni")
9 import("//build/toolchain/cc_wrapper.gni") 9 import("//build/toolchain/cc_wrapper.gni")
10 import("//build/toolchain/toolchain.gni") 10 import("//build/toolchain/toolchain.gni")
(...skipping 1557 matching lines...) Expand 10 before | Expand all | Expand 10 after
1568 1568
1569 if (is_ios || is_mac) { 1569 if (is_ios || is_mac) {
1570 # On Mac and iOS, this enables support for ARC (automatic ref-counting). 1570 # On Mac and iOS, this enables support for ARC (automatic ref-counting).
1571 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html. 1571 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html.
1572 config("enable_arc") { 1572 config("enable_arc") {
1573 common_flags = [ "-fobjc-arc" ] 1573 common_flags = [ "-fobjc-arc" ]
1574 cflags_objc = common_flags 1574 cflags_objc = common_flags
1575 cflags_objcc = common_flags 1575 cflags_objcc = common_flags
1576 } 1576 }
1577 } 1577 }
1578
1579 #
1580 # Extra flags
1581 #
1582 # This is a placeholder config so that users with custom toolchains
1583 # can more easily set extra flags to be passed to each target, while
1584 # still allowing for those flags to be turned off on a per-target basis.
1585
1586 config("extra_flags") {
1587 # We generally do not want people to specify extra flags, so for now
1588 # this hook is only exposed to the actual CrOS builds (the simplechrome
1589 # and ebuild builds, not the "desktop chromeos" build). We do that
1590 # by checking for the custom_toolchain specifically, rather than
1591 # just checking if `target_os == "chromeos"`.
1592 if (default_toolchain == "//build/toolchain/cros:target") {
1593 configs = [ "//build/config/cros:extra_flags" ]
1594 }
1595 }
OLDNEW
« no previous file with comments | « build/config/BUILDCONFIG.gn ('k') | build/config/cros/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698