Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: build/config/BUILDCONFIG.gn

Issue 2202873002: Rework approach to allowing extra flags for CrOS builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add_cros_nacl_bootstrap_args
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | build/config/compiler/BUILD.gn » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # ============================================================================= 5 # =============================================================================
6 # PLATFORM SELECTION 6 # PLATFORM SELECTION
7 # ============================================================================= 7 # =============================================================================
8 # 8 #
9 # There are two main things to set: "os" and "cpu". The "toolchain" is the name 9 # There are two main things to set: "os" and "cpu". The "toolchain" is the name
10 # of the GN thing that encodes combinations of these things. 10 # of the GN thing that encodes combinations of these things.
(...skipping 482 matching lines...) Expand 10 before | Expand all | Expand 10 after
493 ] 493 ]
494 } 494 }
495 495
496 # Debug/release-related defines. 496 # Debug/release-related defines.
497 if (is_debug) { 497 if (is_debug) {
498 default_compiler_configs += [ "//build/config:debug" ] 498 default_compiler_configs += [ "//build/config:debug" ]
499 } else { 499 } else {
500 default_compiler_configs += [ "//build/config:release" ] 500 default_compiler_configs += [ "//build/config:release" ]
501 } 501 }
502 502
503 # Lastly, add a setting to give toolchains an extra chance to override
504 # flags as needed.
505 default_compiler_configs += [ "//build/config/compiler:extra_flags" ]
506
503 # Static libraries and source sets use only the compiler ones. 507 # Static libraries and source sets use only the compiler ones.
504 set_defaults("static_library") { 508 set_defaults("static_library") {
505 configs = default_compiler_configs 509 configs = default_compiler_configs
506 } 510 }
507 set_defaults("source_set") { 511 set_defaults("source_set") {
508 configs = default_compiler_configs 512 configs = default_compiler_configs
509 } 513 }
510 514
511 # Compute the set of configs common to all linked targets (shared libraries, 515 # Compute the set of configs common to all linked targets (shared libraries,
512 # loadable modules, executables) to avoid duplication below. 516 # loadable modules, executables) to avoid duplication below.
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
622 set_defaults("component") { 626 set_defaults("component") {
623 if (is_component_build) { 627 if (is_component_build) {
624 configs = default_shared_library_configs 628 configs = default_shared_library_configs
625 if (is_android) { 629 if (is_android) {
626 configs -= [ "//build/config/android:hide_native_jni_exports" ] 630 configs -= [ "//build/config/android:hide_native_jni_exports" ]
627 } 631 }
628 } else { 632 } else {
629 configs = default_compiler_configs 633 configs = default_compiler_configs
630 } 634 }
631 } 635 }
OLDNEW
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | build/config/compiler/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698