Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2202853004:
Enable ImeThread feature as default for M54 (Closed)
|
Created:
4 years, 4 months ago by Changwan Ryu Modified:
4 years, 4 months ago CC:
chromium-reviews, darin-cc_chromium.org, jam Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionEnable ImeThread feature as default for M54
We are finch-experimenting this feature on M53. With dev experiment so
far, we could not find any problem. By enabling it by default on M54,
we will try to understand its impact on WebView better, and be ready to
launch this feature 100% on M54.
Also, do not crash even when registration fails since they are most
likely caused by view focus loss or window detachment, in which cases
we do not need to register anyways.
BUG=551193
Committed: https://crrev.com/48bb40190a6331401cc77e85c00fda2184a84292
Cr-Commit-Position: refs/heads/master@{#411008}
Patch Set 1 #
Messages
Total messages: 24 (12 generated)
The CQ bit was checked by changwan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
changwan@chromium.org changed reviewers: + aelias@chromium.org
aelias@chromium.org changed reviewers: + sievers@chromium.org
lgtm, adding sievers@ for content/ OWNERS.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
On 2016/08/03 02:02:07, aelias wrote: > lgtm, adding sievers@ for content/ OWNERS. FYI, the test failure is tracked as crbug.com/633840.
lgtm
The CQ bit was checked by changwan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by changwan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by changwan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/08/10 07:40:24, commit-bot: I haz the power wrote: > CQ is trying da patch. Follow status at > > https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... Test failure at #18 seems to be orthogonal to this patch: https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel... Retrying...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Enable ImeThread feature as default for M54 We are finch-experimenting this feature on M53. With dev experiment so far, we could not find any problem. By enabling it by default on M54, we will try to understand its impact on WebView better, and be ready to launch this feature 100% on M54. Also, do not crash even when registration fails since they are most likely caused by view focus loss or window detachment, in which cases we do not need to register anyways. BUG=551193 ========== to ========== Enable ImeThread feature as default for M54 We are finch-experimenting this feature on M53. With dev experiment so far, we could not find any problem. By enabling it by default on M54, we will try to understand its impact on WebView better, and be ready to launch this feature 100% on M54. Also, do not crash even when registration fails since they are most likely caused by view focus loss or window detachment, in which cases we do not need to register anyways. BUG=551193 Committed: https://crrev.com/48bb40190a6331401cc77e85c00fda2184a84292 Cr-Commit-Position: refs/heads/master@{#411008} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/48bb40190a6331401cc77e85c00fda2184a84292 Cr-Commit-Position: refs/heads/master@{#411008} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
