Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2202843002:
Pass a minimally sized buffer to BoringSSL's HMAC(). (Closed)
DescriptionPass a minimally sized buffer to BoringSSL's HMAC().
BUG=boringssl:59
Committed: https://crrev.com/54a868bdc037722972a1b38721a97a14f73ed735
Cr-Commit-Position: refs/heads/master@{#409271}
Patch Set 1 #Patch Set 2 #
Total comments: 4
Patch Set 3 : address david's feedback #Messages
Total messages: 24 (18 generated)
The CQ bit was checked by eroman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by eroman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by eroman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
eroman@chromium.org changed reviewers: + davidben@chromium.org
Is this the right way of referencing a boringssl bug?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm On 2016/08/01 23:35:23, eroman wrote: > Is this the right way of referencing a boringssl bug? You want BUG=boringssl:59 Which may or may not work if bugdroid isn't configured to allow src.git -> boringssl postings? Or maybe that's changed with Monorail. We'll see. (The native syntax is project:bugnumber. Repositories just have default projects configured.) https://codereview.chromium.org/2202843002/diff/20001/components/webcrypto/al... File components/webcrypto/algorithms/hmac.cc (right): https://codereview.chromium.org/2202843002/diff/20001/components/webcrypto/al... components/webcrypto/algorithms/hmac.cc:104: if (!success) Optional: You can also just write: if (!HMAC(....)) { return Status::OperationError(); } https://codereview.chromium.org/2202843002/diff/20001/components/webcrypto/al... components/webcrypto/algorithms/hmac.cc:111: } CHECK_EQ(hmac_expected_length, hmac_actual_length);
Description was changed from ========== Pass a minimally sized buffer to BoringSSL's HMAC(). BUG=https://bugs.chromium.org/p/boringssl/issues/detail?id=59 ========== to ========== Pass a minimally sized buffer to BoringSSL's HMAC(). BUG=boringssl:59 ==========
The CQ bit was checked by eroman@chromium.org to run a CQ dry run
https://codereview.chromium.org/2202843002/diff/20001/components/webcrypto/al... File components/webcrypto/algorithms/hmac.cc (right): https://codereview.chromium.org/2202843002/diff/20001/components/webcrypto/al... components/webcrypto/algorithms/hmac.cc:104: if (!success) On 2016/08/02 18:17:54, davidben wrote: > Optional: You can also just write: > > if (!HMAC(....)) { > return Status::OperationError(); > } Done. https://codereview.chromium.org/2202843002/diff/20001/components/webcrypto/al... components/webcrypto/algorithms/hmac.cc:111: } On 2016/08/02 18:17:54, davidben wrote: > CHECK_EQ(hmac_expected_length, hmac_actual_length); Done.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by eroman@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from davidben@chromium.org Link to the patchset: https://codereview.chromium.org/2202843002/#ps40001 (title: "address david's feedback")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Pass a minimally sized buffer to BoringSSL's HMAC(). BUG=boringssl:59 ========== to ========== Pass a minimally sized buffer to BoringSSL's HMAC(). BUG=boringssl:59 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Pass a minimally sized buffer to BoringSSL's HMAC(). BUG=boringssl:59 ========== to ========== Pass a minimally sized buffer to BoringSSL's HMAC(). BUG=boringssl:59 Committed: https://crrev.com/54a868bdc037722972a1b38721a97a14f73ed735 Cr-Commit-Position: refs/heads/master@{#409271} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/54a868bdc037722972a1b38721a97a14f73ed735 Cr-Commit-Position: refs/heads/master@{#409271} |
