Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 2202803003: [turbofan] Fix invalid comparison operator narrowing. (Closed)

Created:
4 years, 4 months ago by Benedikt Meurer
Modified:
4 years, 4 months ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix invalid comparison operator narrowing. When we narrow a signed32 comparison to uint8 or uint16 representation, we also need to change the condition to unsigned comparisons otherwise the comparison will be done on int16/int8 which interprets the narrowed bits wrong. R=epertoso@chromium.org BUG=v8:5254 Committed: https://crrev.com/a758144329b7ddda258e41ea5d8abfca8595e34c Cr-Commit-Position: refs/heads/master@{#38231}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -34 lines) Patch
M src/compiler/ia32/instruction-selector-ia32.cc View 3 chunks +35 lines, -17 lines 0 comments Download
M src/compiler/instruction-selector-impl.h View 1 chunk +19 lines, -0 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 3 chunks +34 lines, -17 lines 0 comments Download
A test/mjsunit/regress/regress-v8-5254-1.js View 1 chunk +27 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-v8-5254-2.js View 1 chunk +27 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
Benedikt Meurer
4 years, 4 months ago (2016-08-02 07:04:52 UTC) #1
epertoso
lgtm
4 years, 4 months ago (2016-08-02 07:41:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2202803003/1
4 years, 4 months ago (2016-08-02 07:41:52 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-02 07:44:35 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 07:46:26 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a758144329b7ddda258e41ea5d8abfca8595e34c
Cr-Commit-Position: refs/heads/master@{#38231}

Powered by Google App Engine
This is Rietveld 408576698