GN: use the correct fontconfig font mugger.

GN: use the correct fontconfig font mugger.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2202733002

Committed: https://skia.googlesource.com/skia/+/7a34b1cd02ae65f2fb299752ebececec2b4f4285

[mtklein_C, 2016-08-01 19:42:38]

Description was changed from

==========
GN: use the correct fontconfig font mugger.

BUG=skia:
==========

to

==========
GN: use the correct fontconfig font mugger.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2202733002
==========

[mtklein_C, 2016-08-01 19:46:26]

mtklein@chromium.org changed reviewers:
+ bungeman@google.com

[mtklein_C, 2016-08-01 19:46:27]

The CQ bit was checked by mtklein@chromium.org

[commit-bot: I haz the power, 2016-08-01 19:46:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bungeman-skia, 2016-08-01 20:03:17]

lgtm, with notes about what may or may not want to be included.

https://codereview.chromium.org/2202733002/diff/20001/BUILD.gn
File BUILD.gn (left):

https://codereview.chromium.org/2202733002/diff/20001/BUILD.gn#oldcode260
BUILD.gn:260: "src/fonts/SkFontMgr_fontconfig.cpp",
If this build file is designed for building and testing as many files as
possible, leaving this one in should be ok (otherwise we're only building it
when rolling into Chromium).

https://codereview.chromium.org/2202733002/diff/20001/BUILD.gn#oldcode265
BUILD.gn:265: "src/ports/SkFontHost_fontconfig.cpp",
This file should actually be named SkFontMgr_FCI_factory.cpp, and as such will
conflict with the other SkFontMgr_XXX_factory.cpp files.

[mtklein, 2016-08-01 20:05:54]

mtklein@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2016-08-01 20:05:55]

https://codereview.chromium.org/2202733002/diff/20001/BUILD.gn
File BUILD.gn (left):

https://codereview.chromium.org/2202733002/diff/20001/BUILD.gn#oldcode260
BUILD.gn:260: "src/fonts/SkFontMgr_fontconfig.cpp",
On 2016/08/01 20:03:17, bungeman-skia wrote:
> If this build file is designed for building and testing as many files as
> possible, leaving this one in should be ok (otherwise we're only building it
> when rolling into Chromium).

Nah, quite the opposite.  For now I don't want anything that we don't need.

[commit-bot: I haz the power, 2016-08-01 20:08:49]

Description was changed from

==========
GN: use the correct fontconfig font mugger.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2202733002
==========

to

==========
GN: use the correct fontconfig font mugger.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2202733002

Committed:
https://skia.googlesource.com/skia/+/7a34b1cd02ae65f2fb299752ebececec2b4f4285
==========

[commit-bot: I haz the power, 2016-08-01 20:08:50]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/7a34b1cd02ae65f2fb299752ebececec2b4f4285